Rate limit on fetching Tetra Channel information for players in room

[mat1jaczyyy]

if a room has 10+ people it's possible to hit rate limit on channelApi here, which takes down the entire node process:

tetr.js/src/ws/commands/room.update.ts

Lines 92 to 94 in 226bf41

	data.players.map(async ({ _id, bracket }: any) => {
	return [_id, { user: await client.fetchUser(_id), bracket }];
	})

/srv/eucannon-prod/bot/node_modules/tetr.js/dist/util/channelApi.js:34
            throw Error((yield response).error);
                  ^

Error: Rate limit exceeded! | You are doing that far too quickly.
    at /srv/eucannon-prod/bot/node_modules/tetr.js/dist/util/channelApi.js:34:19
    at Generator.next (<anonymous>)
    at fulfilled (/srv/eucannon-prod/bot/node_modules/tetr.js/dist/util/channelApi.js:5:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

[mat1jaczyyy]

do you expect the newly implemented err/kick/nope handling to handle this case, allowing us to log the error and only taking down that client instead of the entire process?

[Sup3rFire]

the newly implemented err/kick/nope only emits the respective events that are sent from the server

[mat1jaczyyy]

the newly implemented err/kick/nope only emits the respective events that are sent from the server

can you pls try catch this somehow and stall for a second or two and try again on exception?

we got a 100 entrant tournament rn and this is looking scary as hell

or maybe allow for caching the channelApi results and only fetching them once ever

[Genius6942]

Use the game api instead of tetr channel (no rate limit) https://tetr.io/api/users/${userid}

[mat1jaczyyy]

big if true, is he right

[Sup3rFire]

seems like the rate limit is a lot higher there yes

[Sup3rFire]

ill change this in a later update since using tetrchannel isnt really causing problems for now

[mat1jaczyyy]

well it didnt happen last month but it just happened again right now, luckily it's stream room so no big deal but if this were to happen mid tournament we are shitting bricks

2024-06-02 14:12:43.077  [Room KSQR] Replay saved! IDreplay=614 for IDmatch=811
/srv/eucannon-prod/bot/node_modules/tetr.js/dist/util/channelApi.js:35
            throw Error((yield response).error);
                  ^

Error: Rate limit exceeded! | You are doing that far too quickly.
    at /srv/eucannon-prod/bot/node_modules/tetr.js/dist/util/channelApi.js:35:19
    at Generator.next (<anonymous>)
    at fulfilled (/srv/eucannon-prod/bot/node_modules/tetr.js/dist/util/channelApi.js:5:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

[Sup3rFire]

ok nvm ill implement it soon then