assertEqualsDeep(Set, Set, String) fails when it shouldn't

[Philzen]

TestNG Version

Discovered on 7.5.1 and confirmed on 7.10.2

Expected behavior

assertEqualsDeep should probably have similar behaviour with Sets as with Maps.

This will pass:

Assert.assertEqualsDeep(
    Map.of("foo", new String[] {"foo"}, "map", Map.of()), 
    Map.of("foo", new String[] {"foo"}, "map", Map.of()), 
    "Not equal"
);

While this will not:

Assert.assertEqualsDeep(
    Set.of(new String[] {"foo"}, Map.of()), 
    Set.of(new String[] {"foo"}, Map.of()), 
    "Not equal"
);

Root cause

testng/testng-asserts/src/main/java/org/testng/Assert.java

Lines 2070 to 2072 in 0f779fe

	if (!areEqualImpl(value, expected)) {
	return "Sets not equal: expected: " + expectedValue + " and actual: " + value;
	}

This should probably be areEqualImpl(value, expectedValue) instead – expected is the whole Set and here it is compared with the current actual value from the iterator, which will always fail.

Is the issue reproducible on runner?

• Shell
• Maven
• Gradle
• Ant
• Eclipse
• IntelliJ
• NetBeans

Probably everywhere.

[juherr]

Thanks for the report.

Could you propose a fix in a pull request ?