From 6dd48477002760262652dd047de0897762bd60c4 Mon Sep 17 00:00:00 2001 From: Vlad Lashko Date: Sat, 16 Jul 2022 22:12:56 +0300 Subject: [PATCH] fix: missing optional parameter for emitted (#276) --- src/__tests__/form.js | 2 +- src/__tests__/user-event.js | 2 +- src/render.js | 2 +- types/index.d.ts | 1 + types/index.test-d.ts | 1 + 5 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/__tests__/form.js b/src/__tests__/form.js index 5011b359..94b460a7 100644 --- a/src/__tests__/form.js +++ b/src/__tests__/form.js @@ -62,6 +62,6 @@ test('Review form submits', async () => { // Assert the right event has been emitted. expect(emitted()).toHaveProperty('submit') - expect(emitted().submit[0][0]).toMatchObject(fakeReview) + expect(emitted('submit')[0][0]).toMatchObject(fakeReview) expect(console.warn).not.toHaveBeenCalled() }) diff --git a/src/__tests__/user-event.js b/src/__tests__/user-event.js index 4db8c3e6..ed02bfbf 100644 --- a/src/__tests__/user-event.js +++ b/src/__tests__/user-event.js @@ -53,7 +53,7 @@ test('User events in a form', async () => { expect(submitButton).toHaveFocus() expect(submitButton).toBeEnabled() userEvent.type(submitButton, '{enter}') - expect(emitted().submit[0][0]).toMatchObject(fakeReview) + expect(emitted('submit')[0][0]).toMatchObject(fakeReview) expect(console.warn).not.toHaveBeenCalled() }) diff --git a/src/render.js b/src/render.js index b07b97cf..6f635cb2 100644 --- a/src/render.js +++ b/src/render.js @@ -45,7 +45,7 @@ Check out the test examples on GitHub for further details.`) : console.log(prettyDOM(el, maxLength, options)), unmount: () => wrapper.unmount(), html: () => wrapper.html(), - emitted: () => wrapper.emitted(), + emitted: name => wrapper.emitted(name), rerender: props => wrapper.setProps(props), ...getQueriesForElement(baseElement), } diff --git a/types/index.d.ts b/types/index.d.ts index b6037f31..c6c157d7 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -24,6 +24,7 @@ export interface RenderResult extends BoundFunctions { unmount(): void html(): string emitted(): Record + emitted(name?: string): T[] rerender(props: object): Promise } diff --git a/types/index.test-d.ts b/types/index.test-d.ts index 8ec7e117..09ad1fd1 100644 --- a/types/index.test-d.ts +++ b/types/index.test-d.ts @@ -86,6 +86,7 @@ export function testOptions() { export function testEmitted() { const {emitted} = render(SomeComponent) expectType(emitted().foo) + expectType(emitted('foo')) } /*