Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for moving from legacy driver? #85

Open
nacc opened this issue Jan 14, 2021 · 4 comments
Open

Plans for moving from legacy driver? #85

nacc opened this issue Jan 14, 2021 · 4 comments

Comments

@nacc
Copy link
Contributor

nacc commented Jan 14, 2021

🗣️ Foreword

Thank for taking the time to fill this feature request fully. Without it we may not be able to , and the issue may be closed without resolution.

🙍 Problem Statement

In trying to work through some hairy chef-internal changes that I needed to stage, I was hoping to leverage some provisioner: variables (e.g., retry_on_exit_code). However, because kitchen-digitalocean is a "legacy" Driver (inherits from SSHBase, aiui), the provisioner variables aren't actually used, because the driver does the converge (over ssh) rather than the provisioner.

❔ Possible Solution

I am not entirely sure what is necessary to not be a legacy Driver, but I'm happy to invest time to do the code changes. I want to find out, first, though, if there is interest in that being done and if such a PR would be acceptable.

⤴️ Describe alternatives you've considered

I suppose an alternative would be to add support for those variables to the kitchen-digitalocean Driver directly, but that seems like the wrong direction if deprecation of legacy Drivers is really the intention upstream.

@marcparadise
Copy link

@tas50 any thoughts on this?

@tas50
Copy link
Member

tas50 commented Jun 23, 2021

One of the tasks for the new team is to cleanup internal implementations of all the drives so this is on the list.

@nacc
Copy link
Contributor Author

nacc commented Jun 23, 2021

Ty!

@nacc
Copy link
Contributor Author

nacc commented Sep 22, 2021

@tas50 do you have any links to what is needed to update the implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants