[Bug]: New Role Duplication [Low Priority] [Low/Medium Impact]

[ExtrovertedLimpet]

Bug Description

When in the roles main menu, creating a role, deleting it, and creating a role again will create 2 roles, doing it three times will create three roles.

Expected output: When deleting and creating new roles I expect 1 new role to be created every time I press create a new role.

Observed output: When deleting and creating new roles (without saving) all previously removed roles come back at once so the amount of newly created roles = newly created roles + previously deleted roles (in the same session meaning no saving in between).

How to Reproduce?

Workflow is shown below:

Create New Role ─────► One New Role Created

                Total new roles: 1

Delete New Role─────────► New Role Deleted

               Total new roles: 0

Create New Role ───────► New Role 1 Created

                         New Role 2 Created

              Total new roles: 2

Delete Both roles ────────────► Deleted roles

               Total new roles: 0

Create new Role ───────────────► New Role 1 Created

                                 New Role 2 Created

                                 New Role 3 Created

                 Total new roles: 3

Important! Do not save in between steps! Steps are the ones in the left of the arrow

Expected Behavior

Expected output: When deleting and creating new roles I expect 1 new role to be created every time I press create a new role.

Version

1.2.0

Mod Loader Version

0.14.19

Mod Loader

Fabric

Logs or additional context

No response

Code of Conduct

• I have searched the issue tracker and confirmed that the issue has not been reported
• I have checked the FAQ (if one is present) and my issue is not listed
• I have verified that I am using the latest version of the mod
• I have verified that I have installed all the required dependencies for the mod
• I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.