feat: update security group logic #422

mounika-nalla · 2023-04-07T00:03:00Z

Description

Replace security group logic with the security group module
fixes #410

Types of changes in this PR

No release required

Examples or tests (addition or updates of examples or tests)
Documentation update
CI-related update (pipeline, etc.)
Other changes that don't affect Terraform code

Release required

Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content

Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".
Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.

The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

ocofaigh · 2023-04-07T15:05:59Z

@mounika-nalla The upgrade test failed because it has identified an update to the network_acl. Can you confirm if this is expected? If so we will need to temporarily add module.slz_vpc.ibm_is_network_acl.network_acl["vpc-acl"] to the ignore list in pr_test.go to allow upgrade to test. But first please confirm this is expected:

Messages:   	Resource(s) identified to be updated Name: network_acl Address: module.slz_vpc.ibm_is_network_acl.network_acl["vpc-acl"] Actions: [update]
        	            	DIFF:
        	            	Before: {"rules":[{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"ed853e71-1a32-4f7c-aafd-5c84a72915d9","ip_version":"ipv4","name":"ibmflow-iaas-inbound","source":"161.26.0.0/16","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"161.26.0.0/16","direction":"outbound","icmp":[],"id":"0d5f650e-5dcf-41d6-9bf9-4b38a4974bce","ip_version":"ipv4","name":"ibmflow-iaas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"b64f770f-608c-4331-8786-f330d8bcc68e","ip_version":"ipv4","name":"ibmflow-paas-inbound","source":"166.8.0.0/14","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"166.8.0.0/14","direction":"outbound","icmp":[],"id":"d4a51721-7afc-468e-8000-978c79819612","ip_version":"ipv4","name":"ibmflow-paas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"07f265f3-88e6-471d-a3ad-1fadafba4c1c","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"outbound","icmp":[],"id":"dc925ad5-6cda-4ab0-a9c7-ace24fb6dc7f","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"0.0.0.0/0","direction":"inbound","icmp":[],"id":"dc55289c-26d0-458e-a352-d7a1f87be5f1","ip_version":"ipv4","name":"allow-all-443-inbound","source":"0.0.0.0/0","subnets":3,"tcp":[{"port_max":443,"port_min":443,"source_port_max":65535,"source_port_min":1}],"udp":[]},{"action":"allow","destination":"0.0.0.0/0","direction":"outbound","icmp":[],"id":"f4eead85-febc-46ff-b62f-5e1cfea2fe30","ip_version":"ipv4","name":"allow-all-443-outbound","source":"0.0.0.0/0","subnets":3,"tcp":[{"port_max":65535,"port_min":1,"source_port_max":443,"source_port_min":443}],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"inbound","icmp":[],"id":"0701b4a3-f309-4288-8642-45f5a3400d94","ip_version":"ipv4","name":"ibmflow-deny-all-inbound","source":"0.0.0.0/0","subnets":3,"tcp":[],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"outbound","icmp":[],"id":"c8dd00dc-6972-4c71-94e5-70f0b7d39cf4","ip_version":"ipv4","name":"ibmflow-deny-all-outbound","source":"0.0.0.0/0","subnets":3,"tcp":[],"udp":[]}]}
        	            	After: {"rules":[{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"ed853e71-1a32-4f7c-aafd-5c84a72915d9","ip_version":"ipv4","name":"ibmflow-iaas-inbound","source":"161.26.0.0/16","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"161.26.0.0/16","direction":"outbound","icmp":[],"id":"0d5f650e-5dcf-41d6-9bf9-4b38a4974bce","ip_version":"ipv4","name":"ibmflow-iaas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"b64f770f-608c-4331-8786-f330d8bcc68e","ip_version":"ipv4","name":"ibmflow-paas-inbound","source":"166.8.0.0/14","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"166.8.0.0/14","direction":"outbound","icmp":[],"id":"d4a51721-7afc-468e-8000-978c79819612","ip_version":"ipv4","name":"ibmflow-paas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"07f265f3-88e6-471d-a3ad-1fadafba4c1c","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-23a9","source":"10.240.0.0/18","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"dc925ad5-6cda-4ab0-a9c7-ace24fb6dc7f","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-74bc","source":"10.240.64.0/18","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"dc55289c-26d0-458e-a352-d7a1f87be5f1","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-767d","source":"10.240.128.0/18","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"f4eead85-febc-46ff-b62f-5e1cfea2fe30","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-04b2","source":"10.10.10.0/24","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"0701b4a3-f309-4288-8642-45f5a3400d94","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-1dc5","source":"10.30.10.0/24","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"c8dd00dc-6972-4c71-94e5-70f0b7d39cf4","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-9aa4","source":"10.20.10.0/24","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.240.0.0/18","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-tion","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.240.64.0/18","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-dled","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.240.128.0/18","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-lude","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.10.10.0/24","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-et-a","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.30.10.0/24","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-et-c","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.20.10.0/24","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-et-b","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"inbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-deny-all-inbound","source":"0.0.0.0/0","subnets":null,"tcp":[],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-deny-all-outbound","source":"0.0.0.0/0","subnets":null,"tcp":[],"udp":[]}]}

mounika-nalla · 2023-04-07T16:46:53Z

@mounika-nalla The upgrade test failed because it has identified an update to the network_acl. Can you confirm if this is expected? If so we will need to temporarily add module.slz_vpc.ibm_is_network_acl.network_acl["vpc-acl"] to the ignore list in pr_test.go to allow upgrade to test. But first please confirm this is expected:

Messages:   	Resource(s) identified to be updated Name: network_acl Address: module.slz_vpc.ibm_is_network_acl.network_acl["vpc-acl"] Actions: [update]
        	            	DIFF:
        	            	Before: {"rules":[{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"ed853e71-1a32-4f7c-aafd-5c84a72915d9","ip_version":"ipv4","name":"ibmflow-iaas-inbound","source":"161.26.0.0/16","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"161.26.0.0/16","direction":"outbound","icmp":[],"id":"0d5f650e-5dcf-41d6-9bf9-4b38a4974bce","ip_version":"ipv4","name":"ibmflow-iaas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"b64f770f-608c-4331-8786-f330d8bcc68e","ip_version":"ipv4","name":"ibmflow-paas-inbound","source":"166.8.0.0/14","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"166.8.0.0/14","direction":"outbound","icmp":[],"id":"d4a51721-7afc-468e-8000-978c79819612","ip_version":"ipv4","name":"ibmflow-paas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"07f265f3-88e6-471d-a3ad-1fadafba4c1c","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"outbound","icmp":[],"id":"dc925ad5-6cda-4ab0-a9c7-ace24fb6dc7f","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"0.0.0.0/0","direction":"inbound","icmp":[],"id":"dc55289c-26d0-458e-a352-d7a1f87be5f1","ip_version":"ipv4","name":"allow-all-443-inbound","source":"0.0.0.0/0","subnets":3,"tcp":[{"port_max":443,"port_min":443,"source_port_max":65535,"source_port_min":1}],"udp":[]},{"action":"allow","destination":"0.0.0.0/0","direction":"outbound","icmp":[],"id":"f4eead85-febc-46ff-b62f-5e1cfea2fe30","ip_version":"ipv4","name":"allow-all-443-outbound","source":"0.0.0.0/0","subnets":3,"tcp":[{"port_max":65535,"port_min":1,"source_port_max":443,"source_port_min":443}],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"inbound","icmp":[],"id":"0701b4a3-f309-4288-8642-45f5a3400d94","ip_version":"ipv4","name":"ibmflow-deny-all-inbound","source":"0.0.0.0/0","subnets":3,"tcp":[],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"outbound","icmp":[],"id":"c8dd00dc-6972-4c71-94e5-70f0b7d39cf4","ip_version":"ipv4","name":"ibmflow-deny-all-outbound","source":"0.0.0.0/0","subnets":3,"tcp":[],"udp":[]}]}
        	            	After: {"rules":[{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"ed853e71-1a32-4f7c-aafd-5c84a72915d9","ip_version":"ipv4","name":"ibmflow-iaas-inbound","source":"161.26.0.0/16","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"161.26.0.0/16","direction":"outbound","icmp":[],"id":"0d5f650e-5dcf-41d6-9bf9-4b38a4974bce","ip_version":"ipv4","name":"ibmflow-iaas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"b64f770f-608c-4331-8786-f330d8bcc68e","ip_version":"ipv4","name":"ibmflow-paas-inbound","source":"166.8.0.0/14","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"166.8.0.0/14","direction":"outbound","icmp":[],"id":"d4a51721-7afc-468e-8000-978c79819612","ip_version":"ipv4","name":"ibmflow-paas-outbound","source":"10.0.0.0/8","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"07f265f3-88e6-471d-a3ad-1fadafba4c1c","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-23a9","source":"10.240.0.0/18","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"dc925ad5-6cda-4ab0-a9c7-ace24fb6dc7f","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-74bc","source":"10.240.64.0/18","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"dc55289c-26d0-458e-a352-d7a1f87be5f1","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-767d","source":"10.240.128.0/18","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"f4eead85-febc-46ff-b62f-5e1cfea2fe30","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-04b2","source":"10.10.10.0/24","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"0701b4a3-f309-4288-8642-45f5a3400d94","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-1dc5","source":"10.30.10.0/24","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.0.0.0/8","direction":"inbound","icmp":[],"id":"c8dd00dc-6972-4c71-94e5-70f0b7d39cf4","ip_version":"ipv4","name":"ibmflow-allow-vpc-connectivity-inbound-9aa4","source":"10.20.10.0/24","subnets":3,"tcp":[],"udp":[]},{"action":"allow","destination":"10.240.0.0/18","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-tion","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.240.64.0/18","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-dled","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.240.128.0/18","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-lude","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.10.10.0/24","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-et-a","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.30.10.0/24","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-et-c","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"allow","destination":"10.20.10.0/24","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-allow-vpc-connectivity-outbound-et-b","source":"10.0.0.0/8","subnets":null,"tcp":[],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"inbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-deny-all-inbound","source":"0.0.0.0/0","subnets":null,"tcp":[],"udp":[]},{"action":"deny","destination":"0.0.0.0/0","direction":"outbound","icmp":[],"id":null,"ip_version":null,"name":"ibmflow-deny-all-outbound","source":"0.0.0.0/0","subnets":null,"tcp":[],"udp":[]}]}

Yes, these are expected because of the version bump of terraform-ibm-landing-zone-vpc from 4.2 to 5.2. The updates involved here are the unique names to the acls, changes to source and destination. I have updated the PR ignoring module.slz_vpc.ibm_is_network_acl.network_acl["vpc-acl”]. I will remove it once the PR is merged.

vburckhardt

Hi @mounika-nalla - couple of comments

variables.tf

vburckhardt

👍

vburckhardt

Double checking this PR - I do not see any moved block to ensure backward compatibility. At the same time, we definitely now that address references would change in the state file from the code in this PR.

The tests are not failing because security group is not created in the default example - hense the security group logic is not exercises.

Could you update the default example to get the module to create a new security group. I suspect that's where we'll see that the change is not backward compatible.

See my comment - found a potential issue when double checking the PR code.

mounika-nalla · 2023-04-21T00:25:35Z

@vburckhardt From my tests, I believe usage of moved blocks is not possible here.

the blocks changed are:

from = ibm_is_security_group.security_group[load_balancer.security_group.name]
 to   = module.security_group_rules[load_balancer.security_group.name]

For the above block, we are required to use a static value instead of load_balancer.security_group.name and since we are not using any default values, the error - A single static variable reference is required: only attribute access and indexing with constant keys is returned

and for the below block, since we are changing from a resource to a module, I’m getting the below noted errors

# error in the below line - Unexpected extra operators after address 
  from = ibm_is_security_group.security_group["test-sgr"].id
# error in the below line - Resource specification must include a resource type and name.
  to   = module.security_group_rules["test-sgr"].security_group_id

Please advise if my understanding is incorrect.

Also, adding the below module call in default example to call the security_group module to create a new security group ran without any compatibility issues. The upgrade test did not complain about any errors.

module "security_group_rules1" {
  source                       = "git::https://github.com/terraform-ibm-modules/terraform-ibm-security-group.git?ref=v1.0.0"
  add_ibm_cloud_internal_rules = var.security_group1.add_ibm_cloud_internal_rules
  security_group_name          = var.security_group1.name
  security_group_rules         = var.security_group1.rules
  resource_group               = local.resource_group_id
  vpc_id                       = module.slz_vpc.vpc_id
}

vburckhardt · 2023-05-04T12:28:06Z

@mounika-nalla - Thanks. I'd suggest going with a script that is made available in the repository to migrate the state. We can then get the release notes to point to the script. The script would

fetch the list of sg rules
fetch the list of sg
use the terraform mv state commands to migrate the state.

See also terraform-ibm-modules/terraform-ibm-landing-zone#253 (comment) for something conceptually equivalent.

We could have another script as well that use the corresponding schematics mv commands for users using IBM Cloud Schematics. I would name the script migrate_state_currentversion_targetversion.sh and put them in a "migrate" directly in the repo.

ocofaigh · 2023-07-20T13:14:19Z

@mounika-nalla what is the latest with this PR?

ocofaigh

Won't this need moved blocks to prevent a breaking change?

mounika-nalla · 2023-07-20T16:43:30Z

Won't this need moved blocks to prevent a breaking change?

We have created a script to manage the state changes as per Vincent's comments above. Using moved blocks is not possible here as we are moving away from using a resource to an attribute.

ocofaigh · 2023-07-20T17:19:51Z

@mounika-nalla Ah ok yes - where is the script?

mounika-nalla · 2023-07-20T17:31:51Z

Its here - migrate/tf_state_migration.sh

ocofaigh · 2023-07-21T08:35:51Z

@mounika-nalla What about schematics users? We will need a script to migrate schematics state too, similar to https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone/blob/extend-output/migration/schematics_migration_v4.4.0_to_v5.0.0.sh

@vburckhardt We need to figure out how to handle this in the SLZ VSI DA that consumes this module. How will a consumer of a DA via projects know they will need to migrate state. Do we bump the major version and document it in cloud docs?

…-landing-zone-vsi into modify-sg-logic

…n vars

MatthewLemmond · 2023-09-28T17:02:01Z

/run pipeline

MatthewLemmond · 2023-09-28T17:12:04Z

/run pipeline

jor2 · 2023-10-04T18:29:59Z

/run pipeline

feat: update security group logic

941f6a8

test: ignore network_acls update

d86e0e7

mounika-nalla requested a review from vburckhardt April 7, 2023 16:58

vburckhardt requested changes Apr 7, 2023

View reviewed changes

variables.tf Outdated Show resolved Hide resolved

variables.tf Outdated Show resolved Hide resolved

mounika-nalla added 2 commits April 7, 2023 17:01

Merge branch 'main' into modify-sg-logic

99dd464

feat: add_ibm_cloud_internal_rules flag

0473454

mounika-nalla force-pushed the modify-sg-logic branch from cb79da0 to 0473454 Compare April 7, 2023 21:18

mounika-nalla added 2 commits April 7, 2023 17:19

feat: add_ibm_cloud_internal_rules flag

c10b3c7

test: update pr_test

f40ce58

vburckhardt self-requested a review April 18, 2023 16:05

vburckhardt previously approved these changes Apr 18, 2023

View reviewed changes

vburckhardt self-requested a review April 18, 2023 16:09

vburckhardt reviewed Apr 18, 2023

View reviewed changes

vburckhardt self-requested a review April 18, 2023 16:12

Merge branch 'main' into modify-sg-logic

e50ab00

mounika-nalla force-pushed the modify-sg-logic branch from c906351 to e50ab00 Compare May 12, 2023 13:31

mounika-nalla added 2 commits May 12, 2023 09:32

feat: script for state mv

ffb6fa5

feat: script for state mv

d4b90ba

Merge branch 'main' into modify-sg-logic

8c44cb0

ocofaigh reviewed Jul 20, 2023

View reviewed changes

mounika-nalla assigned MatthewLemmond Jul 21, 2023

MatthewLemmond added 3 commits September 19, 2023 14:28

Merge branch 'main' of github.com:terraform-ibm-modules/terraform-ibm…

f29daf1

…-landing-zone-vsi into modify-sg-logic

Merge branch 'main' of github.com:terraform-ibm-modules/terraform-ibm…

d76612b

…-landing-zone-vsi into modify-sg-logic

refactor: add translation from source->remote in map, re-add source i…

dd36dd0

…n vars

refactor: pre-commit update

27217c8

jor2 added 2 commits October 2, 2023 10:26

Merge branch 'main' into modify-sg-logic

d93dc28

Merge branch 'main' into modify-sg-logic

a9d45aa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update security group logic #422

feat: update security group logic #422

mounika-nalla commented Apr 7, 2023 •

edited by vburckhardt

Loading

ocofaigh commented Apr 7, 2023

mounika-nalla commented Apr 7, 2023

vburckhardt left a comment

vburckhardt left a comment

vburckhardt left a comment

mounika-nalla commented Apr 21, 2023

vburckhardt commented May 4, 2023

ocofaigh commented Jul 20, 2023

ocofaigh left a comment

mounika-nalla commented Jul 20, 2023

ocofaigh commented Jul 20, 2023

mounika-nalla commented Jul 20, 2023

ocofaigh commented Jul 21, 2023 •

edited

Loading

MatthewLemmond commented Sep 28, 2023

MatthewLemmond commented Sep 28, 2023

jor2 commented Oct 4, 2023

feat: update security group logic #422

Are you sure you want to change the base?

feat: update security group logic #422

Conversation

mounika-nalla commented Apr 7, 2023 • edited by vburckhardt Loading

Description

Types of changes in this PR

No release required

Release required

Release notes content

Checklist for reviewers

Merge actions for mergers

ocofaigh commented Apr 7, 2023

mounika-nalla commented Apr 7, 2023

vburckhardt left a comment

Choose a reason for hiding this comment

vburckhardt left a comment

Choose a reason for hiding this comment

vburckhardt left a comment

Choose a reason for hiding this comment

mounika-nalla commented Apr 21, 2023

vburckhardt commented May 4, 2023

ocofaigh commented Jul 20, 2023

ocofaigh left a comment

Choose a reason for hiding this comment

mounika-nalla commented Jul 20, 2023

ocofaigh commented Jul 20, 2023

mounika-nalla commented Jul 20, 2023

ocofaigh commented Jul 21, 2023 • edited Loading

MatthewLemmond commented Sep 28, 2023

MatthewLemmond commented Sep 28, 2023

jor2 commented Oct 4, 2023

mounika-nalla commented Apr 7, 2023 •

edited by vburckhardt

Loading

ocofaigh commented Jul 21, 2023 •

edited

Loading