Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running tfjs-automl in web worker due to old tfjs-core dependency #8186

Closed
PrafulB opened this issue Feb 25, 2024 · 5 comments
Closed
Assignees

Comments

@PrafulB
Copy link

PrafulB commented Feb 25, 2024

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow.js): No
  • TensorFlow.js installed from (npm or script link): npm
  • TensorFlow.js version (use command below): tfjs-automl
  • Browser version:
  • Tensorflow.js Converter Version:

Describe the current behavior
tfjs-automl depends on tfjs-core v3.9.0 , which causes a ReferenceError when run inside a Web Worker. This is documented in issue #6922 .

Describe the expected behavior
Upgrading the dependency in the package.json to tfjs-core v4.0.0+ should resolve this issue. Tried setting the dependency to tfjs-core v4.9.0, and all tests complete successfully.

Happy to submit a PR with the above change if it helps.

@PrafulB PrafulB added the type:bug Something isn't working label Feb 25, 2024
@gaikwadrahul8 gaikwadrahul8 self-assigned this Feb 26, 2024
@gaikwadrahul8
Copy link
Contributor

Hi, @PrafulB

Thanks for bringing this issue to our attention! I understand that the current dependency on tfjs-core v3.9.0 in tfjs-automl is causing a ReferenceError when running inside a Web Worker as mentioned in issue #6922. The library should function flawlessly within a Web Worker environment, without encountering any errors.

Upgrading the dependency in package.json to tfjs-core v4.0.0+ is likely to resolve this issue. You've already mentioned that setting the dependency to tfjs-core v4.9.0 successfully passed all tests which aligns with this proposal.

We appreciate your willingness to contribute and submit a pull request to address this issue. Our team will thoroughly review your PR and take appropriate action based on their assessment. Thank you again for your valuable contribution.

Copy link

github-actions bot commented Mar 8, 2024

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Mar 8, 2024
Copy link

This issue was closed due to lack of activity after being marked stale for past 7 days.

Copy link

Are you satisfied with the resolution of your issue?
Yes
No

PrafulB added a commit to PrafulB/tfjs that referenced this issue Apr 23, 2024
Updated the version of the tfjs-core dependency in tfjs-automl to resolve the ReferenceError when run from within a web worker.
@PrafulB
Copy link
Author

PrafulB commented Apr 23, 2024

Apologies for not noticing your response earlier, @gaikwadrahul8 . I've created a PR ( #8256 ) that updates the version of the tfjs-core dependency. All tests run successfully for me.

Appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants