Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Lift Tensor.dimensionGathering() out of swift-models and into swift-apis #1058

Open
BradLarson opened this issue Aug 10, 2020 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@BradLarson
Copy link
Contributor

As part of integrating Deep Q-Networks in swift-models PR #617, the Raw.gatherNd() operator was needed. No extension to Tensor implemented this, so a dimensionGathering() function on Tensor was added here.

This should be lifted up from initial testing in swift-models to be part of swift-apis. The dimensionGathering() name should also be reviewed and renamed if needed. This might be a multi-step process, possibly renaming the old interface in swift-models to avoid a collision, adding the new interface in swift-apis, and then removing the interface in swift-models.

Tests should also be added to verify proper function in swift-apis.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant