From e7995e67b0079de26ea069a4d82124da144abed3 Mon Sep 17 00:00:00 2001 From: Profiler Team Date: Thu, 26 Sep 2024 12:58:12 -0700 Subject: [PATCH] Set default value for useNewBackend to true. This CL is a no-op in Tensorboard Profiler. PiperOrigin-RevId: 679261001 --- .../tf_trace_viewer/tf-trace-viewer.html | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html b/plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html index df5308b1..34b0300a 100644 --- a/plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html +++ b/plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html @@ -463,11 +463,15 @@ _replaceModel: {type: Boolean, value: true}, _hosts: {type: Array, value: []}, _selectedHosts: {type: Array, value: []}, - _useNewBackend: {type: Boolean, value: false}, + _useNewBackend: {type: Boolean, value: true}, // The rect being hovered (represents a trace event). _hoverRect: {type: Object, value: null}, }, + useNewBackend: function() { + return this._useNewBackend && !this._isOss; + }, + ready: function() { // Initiate the trace viewer app. this._traceContainer = document.createElement('track-view-container'); @@ -1022,14 +1026,14 @@ backendToggleButton.classList.add('tooltip'); const tooltipSpan = document.createElement('span'); tooltipSpan.classList.add('tooltiptext'); - tooltipSpan.textContent = 'The new backend enables faster trace data processing and also full trace search.'; + tooltipSpan.textContent = 'The new backend enables full trace search and faster trace data processing.'; const labelDiv = document.createElement('div'); - labelDiv.textContent = this._useNewBackend ? 'Switch to Old Backend' : 'Switch to New Backend'; + labelDiv.textContent = this.useNewBackend() ? 'Switch to Old Backend' : 'Switch to New Backend'; backendToggleButton.appendChild(labelDiv); backendToggleButton.appendChild(tooltipSpan); backendToggleButton.addEventListener('click', () => { const url = new URL(`/trace_viewer/${this._sessionId}`, window.location.href); - url.searchParams.set('new_backend', !this._useNewBackend); + url.searchParams.set('new_backend', !this.useNewBackend()); window.open(url.toString()); }); Polymer.dom(this._traceViewer.rightControls).insertBefore(backendToggleButton, detailsSelector); @@ -1201,7 +1205,7 @@ this._createDetailFilter(); if (!this._isOss) { this._createBackendToggleButton(); - if (this._useNewBackend) { + if (this.useNewBackend()) { this._updateSearchBehavior(); } }