Make clicking on the Regenerate button reset the state #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a user of this tool, I don't want to see this feature go. In particular, hitting regenerate during training allows a crude approximation of training with mini-batches (yes, there are better ways to accomplish this, but I'd rather see this fixed properly rather than removed). In general, more on-the-fly changes (e.g. #139) allows for more interesting experimentation for the curious without adding any extra complexity. I'd be happy to hear other points of view though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is intentional to have it keep state when you hit Regenerate but since changing any of the other data parameters reset the state I thought it was a bug.