-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] will desktop support be added again? #64
Comments
Hey. I'd like to at some point, but it isn't on the roadmap for now. First goal was to get things modernized and I'm going to start on additional samples soon. |
Thank you for the quick reply. |
Mainly because it was only working in kind of limited cases, and the API (2.2 I think?) was really far behind. Narrowing the scope helps get things rolling a little faster, then expansions can go back in. From what I could tell with the older repo, desktop support was the last thing to be added in one update, so was still sort of an alpha feature. |
I am not sure which limitations you are talking about as I did never see difference between mobile and desktop. But this can also be due to me not using much of TF Lite just some Conv Nets. Could you maybe somewhere write down the current roadmap? Would be quite interesting to see and maybe also motivate some community contributions. |
Honest answer is there isn't really a current roadmap :p I started getting this plugin back under regular maintenance because I think it's important and shouldn't just sit idle for a few years, but eng/product want to see adoption and results before investing from their teams (I'm in ML DevRel, so a separate area). Next month (during I/O Connect in Amsterdam) I'm talking with someone who works with the FlutterFire team to see how they do their support and feature development now that this has been getting some legs. Other than that, this is still a very-much community pushed project, but I'll try to get a list of things together for it. Now that we're on 2.12, acceleration service and delegates are going to be the next big focus for features I think. I'll talk to product when they're ready to see what priorities should be from there as I ramp up on how this all works under the hood. |
What would be the requirements for a desktop implementation? Depending on how difficult they are, I could invest some work into it. |
I think the biggest thing is thorough testing. Desktop for mac requires Intel based, M1, and M2 testing. I'm not 100% on if it works for Windows (I haven't actually worked with Flutter for Desktop yet), but that could also require some setup and testing. I'd say basically making sure all of the existing samples work would be a solid starting point, then documenting the edge cases where things fall apart. |
I can give it a shot in the coming days. I can try it on Windows and M1 Mac. I guess to to follow the same approach as on mobile, using pre-built binaries would be preffered. Is there a repo (or something) with desktop TF Lite binaries? |
Do you by any chance have experience with
but in flutter it cannot find the library Therefore, I added the
|
Oh no. Yeah I honestly don't know - let me ping some iOS folks to see what they think. My guess is you're going to run into the same issue with style transfer and super resolution, as well, since they also access the library gallery and camera. |
Might also be a good StackOverflow question since it's less TFLite related and more platform in general. |
The app actually compiles fine and there happens a runtime exception when pressing the button. I can adapt the examples to use file picker. Then it can be tested on Desktop. |
To be honest, there are already a lot of question on SO about this (some indicator that it's not that obvious how to do it). I tried a few with no success, would really appreciate some guidance on this as I have nearly no experience in this regard. Windows and Linux should be much easier for me as they use CMake. |
Has there been any progress? |
@allyssonmast see here |
Going to close this since you've done the work for MacOS and know what's going on :) |
Basically, what the title says. The old repo had desktop support and it has been removed in this repo. Are there plans for supporting desktop platforms again?
The text was updated successfully, but these errors were encountered: