Skip to content

TypeError: __init__() got an unexpected keyword argument 'feature_whitelist' #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Aug 7, 2021 · 3 comments · May be fixed by #189
Closed

TypeError: __init__() got an unexpected keyword argument 'feature_whitelist' #188

ghost opened this issue Aug 7, 2021 · 3 comments · May be fixed by #189
Assignees
@pindinagesh
Labels
stat:awaiting response type:docs

Comments

@ghost
Copy link

ghost commented Aug 7, 2021 •
edited by ghost
Loading

According to the documentation of tfdv.StatsOptions, it accepts a parameter called feature_whitelist, which is not true for the website documentation. I'm trying to pass a list of feature names, however I get the following error (tfdv version 1.2.0):

TypeError: __init__() got an unexpected keyword argument 'feature_whitelist'

I understand that the class may be fully functional without that attribute however, the difference in both docs can be misleading.
@arghyaganguly arghyaganguly self-assigned this Aug 9, 2021
@arghyaganguly
Copy link
Contributor

arghyaganguly commented Aug 9, 2021 •
edited
Loading

@schissmantics , thank you for reporting this bug. "feature_whitelist" has been depreciated from tfdv==0.28.0 and replaced with feature_allowlist as mentioned in release note and codebase.

@arghyaganguly arghyaganguly linked a pull request Aug 9, 2021 that will close this issue
Replace feature_whitelist with feature_allowlist in StatsOption #189
Open
@pindinagesh
Copy link

pindinagesh commented Feb 8, 2022 •
edited
Loading

@alternativebug As per above comment "feature_whitelist" has been depreciated from tfdv==0.28.0 and replaced with feature_allowlist, Could you please confirm status on this issue?

@ghost
Copy link
Author

ghost commented Feb 8, 2022

Thanks, I'll take this into consideration next time I come back to this.

@ghost ghost closed this as completed Feb 8, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pindinagesh pindinagesh

Labels
stat:awaiting response type:docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace feature_whitelist with feature_allowlist in StatsOption arghyaganguly/data-validation
2 participants
@arghyaganguly @pindinagesh