Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parafac test suite compares wrong #54

Open
fredrikbk opened this issue Apr 9, 2017 · 1 comment
Open

parafac test suite compares wrong #54

fredrikbk opened this issue Apr 9, 2017 · 1 comment
Assignees

Comments

@fredrikbk
Copy link
Contributor

The parafac test suite compares a tensor to expected data by comparing two sets of values. This results in equality comparison which is too fragile for floating point values. There's also the problem that it doesn't compare values at specific locations in the tensor, just checks that each value exists in the expected set.

I recommend we store expected result as a tensor with some data. Then the result tensor can be compared to the expected tensor with the friend bool equals(const TensorBase&, const TensorBase&); function.

@fredrikbk
Copy link
Contributor Author

fredrikbk commented Apr 9, 2017

For now I removed the test in 3d3617e . Comment it back in when this issue is fixed.

fredrikbk added a commit that referenced this issue Apr 11, 2017
The comparison logic patches the current bad system, but must be
changed see #54
fredrikbk added a commit that referenced this issue Apr 28, 2017
The comparison logic patches the current bad system, but must be
changed see #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants