You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The parafac test suite compares a tensor to expected data by comparing two sets of values. This results in equality comparison which is too fragile for floating point values. There's also the problem that it doesn't compare values at specific locations in the tensor, just checks that each value exists in the expected set.
I recommend we store expected result as a tensor with some data. Then the result tensor can be compared to the expected tensor with the friend bool equals(const TensorBase&, const TensorBase&); function.
The text was updated successfully, but these errors were encountered:
The parafac test suite compares a tensor to expected data by comparing two sets of values. This results in equality comparison which is too fragile for floating point values. There's also the problem that it doesn't compare values at specific locations in the tensor, just checks that each value exists in the expected set.
I recommend we store expected result as a tensor with some data. Then the result tensor can be compared to the expected tensor with the
friend bool equals(const TensorBase&, const TensorBase&);
function.The text was updated successfully, but these errors were encountered: