Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [cosmos_node_client] Transaction signing #257

Open
andrzejchm opened this issue Apr 13, 2022 · 1 comment
Open

[Feature] [cosmos_node_client] Transaction signing #257

andrzejchm opened this issue Apr 13, 2022 · 1 comment
Assignees
Labels
📡 cosmos_node_client issues related to cosmos_node_client package Feature 💡

Comments

@andrzejchm
Copy link
Contributor

Acceptance Criteria

  • introduce new types CosmosTransaction and SignedCosmosTransaction:
class CosmosTransaction {
   final List<GeneratedMessage> messages; //comes from the google's protobuf https://pub.dev/documentation/protobuf/latest/protobuf/GeneratedMessage-class.html
   final String? memo;
   final Fee? fee; //comes from the proto/cosmos/tx protobuf found here: https://github.com/cosmos/cosmos-sdk/blob/master/proto/cosmos/tx/v1beta1/tx.proto
   final 
   
  Future<Either<TransactionSigningFailure, SignedCosmosTransaction> sign(Account account);
  // should mimic the functionality of https://github.com/alan-sdk/alan.dart/blob/604bc3484dafcc9c7634cce088ec8f8c09c96a70/lib/transactions/signer/tx_signer.dart#L41
}


class SignedCosmosTransaction {
    final Tx tx;
}
@andrzejchm andrzejchm added Feature 💡 📡 cosmos_node_client issues related to cosmos_node_client package labels Apr 13, 2022
@Zfinix
Copy link
Contributor

Zfinix commented Apr 20, 2022

Starting work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📡 cosmos_node_client issues related to cosmos_node_client package Feature 💡
Projects
None yet
Development

No branches or pull requests

2 participants