Repository navigation
Show and filter by event group markers - #3986
Draft
laurakwhit wants to merge 3 commits into
Draft
laurakwhit wants to merge 3 commits into
laurakwhit wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR surfaces event group markers in event details and adds a filter for them on Workflow
/historyand/timeline.Event details
createEventGroup) are decoded through the configured codec. When there's no label payload the marker ID is shown instead.<signal name> (<event id>)fromWorkflowExecutionSignaled, and<update name> (<update id>)from the update's Admitted or Accepted event. Without a name they fall back to the event type, and before the source event loads they fall back to the ID.Event Groups filter
/history and/timeline. It only is shown when the history has markers.?groups=(URL-encoded marker keys) and carries over between History and Timeline. Keys not in the current run are ignored, so stale links never empty the view.How it works
event-group-markers.ts) resolves markers into shared entries as events are converted. It handles events arriving out of order from the two-direction history fetch.WeakMap, so each label is decoded once per loaded history.A note on dependency updates
@temporalio/*1.22 → 1.24 – the first versions with the event-group API.nexus-rpc0.0.2 → 0.0.3 – indevDependenciesandpeerDependenciessince SDK 1.24 requires it.protobufjsoverride is split by major version –<8stays pinned to>=7.6.5 <7.7.0for@grpc/proto-loaderand>=8 <9pins>=8.8.0 <8.9.0for the SDK.HistoryEventomits proto's newattributesfield (which names the set attributes field), and the system Nexus demo caller workflow uses a type-only proto import.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
pnpm catalog dev, then run Event marker groups from the catalog./history. Expand an event and check the Event Groups row./history,/timelineand the JSON view narrow. Reload, and switch between/history and/timeline`, to confirm the selection persists.Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
FE-211Docs
Any docs updates needed?