From d6f716e3b3e49f1f00d15e9393c8e0d1b562875e Mon Sep 17 00:00:00 2001 From: Ankit Nayan Date: Fri, 11 Apr 2025 20:14:08 +0530 Subject: [PATCH] Add temporal relevant attributes to spans Add `workflowType`, `activityType`, `namespace`, `taskQueue` attributes to `ExecuteActivity` and `ExecuteWorkflow` spans --- interceptor/tracing_interceptor.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/interceptor/tracing_interceptor.go b/interceptor/tracing_interceptor.go index a1173e763..c2eb29ae9 100644 --- a/interceptor/tracing_interceptor.go +++ b/interceptor/tracing_interceptor.go @@ -42,6 +42,10 @@ const ( runIDTagKey = "temporalRunID" activityIDTagKey = "temporalActivityID" updateIDTagKey = "temporalUpdateID" + activityTypeTagKey = "temporalActivityType" + workflowTypeTagKey = "temporalWorkflowType" + namespaceTagKey = "temporalNamespace" + taskQueueTagKey = "temporalTaskQueue" ) // Tracer is an interface for tracing implementations as used by @@ -453,6 +457,10 @@ func (t *tracingActivityInboundInterceptor) ExecuteActivity( workflowIDTagKey: info.WorkflowExecution.ID, runIDTagKey: info.WorkflowExecution.RunID, activityIDTagKey: info.ActivityID, + activityTypeTagKey: info.ActivityType.Name, + namespaceTagKey: info.WorkflowNamespace, + taskQueueTagKey: info.TaskQueue, + workflowTypeTagKey: info.WorkflowType.Name, }, FromHeader: true, Time: info.StartedTime, @@ -503,6 +511,9 @@ func (t *tracingWorkflowInboundInterceptor) ExecuteWorkflow( Tags: map[string]string{ workflowIDTagKey: t.info.WorkflowExecution.ID, runIDTagKey: t.info.WorkflowExecution.RunID, + workflowTypeTagKey: t.info.WorkflowType.Name, + namespaceTagKey: t.info.Namespace, + taskQueueTagKey: t.info.TaskQueueName, }, FromHeader: true, Time: t.info.WorkflowStartTime, @@ -639,6 +650,9 @@ func (t *tracingWorkflowInboundInterceptor) ExecuteUpdate( workflowIDTagKey: info.WorkflowExecution.ID, runIDTagKey: info.WorkflowExecution.RunID, updateIDTagKey: currentUpdateInfo.ID, + workflowTypeTagKey: t.info.WorkflowType.Name, + namespaceTagKey: t.info.Namespace, + taskQueueTagKey: t.info.TaskQueueName, }, FromHeader: true, Time: time.Now(),