fix: Add additional tests for v2 and squash some bugs

- Added additional test cases
Fixes:
 - Added missing setting of DisableUpdateTracing for `Options()`
 - Add safe type safe assertions to avoid panics
 - Fix temporal. prefix setting

Author: jblacker

contrib/datadog/v2/tracing/interceptor.go

@@ -84,6 +84,7 @@ func (t *tracerImpl) Options() interceptor.TracerOptions {
 		HeaderKey:            headerKey,
 		DisableSignalTracing: t.opts.DisableSignalTracing,
 		DisableQueryTracing:  t.opts.DisableQueryTracing,
+		DisableUpdateTracing: t.opts.DisableUpdateTracing,
 	}
 }
 
@@ -103,7 +104,12 @@ func (t *tracerImpl) UnmarshalSpan(m map[string]string) (interceptor.TracerSpanR
 
 func (t *tracerImpl) MarshalSpan(span interceptor.TracerSpan) (map[string]string, error) {
 	carrier := tracer.TextMapCarrier{}
-	if err := tracer.Inject(span.(*tracerSpan).Context(), carrier); err != nil {
+	tSpan, ok := span.(*tracerSpan)
+	if !ok {
+		return nil, fmt.Errorf("expected *tracerSpan, got %T", span)
+	}
+
+	if err := tracer.Inject(tSpan.Context(), carrier); err != nil {
 		return nil, err
 	}
 	return carrier, nil
@@ -118,7 +124,11 @@ func (t *tracerImpl) SpanFromContext(ctx context.Context) interceptor.TracerSpan
 }
 
 func (t *tracerImpl) ContextWithSpan(ctx context.Context, span interceptor.TracerSpan) context.Context {
-	return tracer.ContextWithSpan(ctx, span.(*tracerSpan).Span)
+	tSpan, ok := span.(*tracerSpan)
+	if !ok {
+		return ctx
+	}
+	return tracer.ContextWithSpan(ctx, tSpan.Span)
 }
 
 // SpanFromWorkflowContext extracts the DataDog Span object from the workflow context.
@@ -147,7 +157,7 @@ func (t *tracerImpl) StartSpan(options *interceptor.TracerStartSpanOptions) (int
 		tracer.ResourceName(options.Name),
 		tracer.StartTime(options.Time),
 	}
-	// Set a deterministic span ID for workflows which are long-running and cross process boundaries
+	// Set a deterministic span ID for workflows which are long-running and cross-process boundaries
 	if options.IdempotencyKey != "" {
 		startOpts = append(startOpts, tracer.WithSpanID(genSpanID(options.IdempotencyKey)))
 	}
@@ -165,7 +175,7 @@ func (t *tracerImpl) StartSpan(options *interceptor.TracerStartSpanOptions) (int
 	case *tracerSpanCtx:
 		parentCtx = opParent.SpanContext
 	default:
-		// This should be considered an error, because something unexpected is
+		// This should be considered an error because something unexpected is
 		// in the place where only a parent trace should be. In this case, we don't
 		// set up the parent, so we will be creating a new top-level span
 	}
@@ -174,7 +184,7 @@ func (t *tracerImpl) StartSpan(options *interceptor.TracerStartSpanOptions) (int
 	for k, v := range options.Tags {
 		// TODO when custom span support is added we might have to revisit this
 		// Display Temporal tags in a nested group in Datadog APM
-		tagKey := "temporal." + strings.TrimPrefix(k, "temporal")
+		tagKey := "temporal." + strings.TrimPrefix(k, "temporal.")
 		startOpts = append(startOpts, tracer.Tag(tagKey, v))
 	}