Merged
Conversation
tconley1428
reviewed
Mar 25, 2026
tconley1428
reviewed
Mar 25, 2026
tconley1428
reviewed
Mar 25, 2026
tconley1428
approved these changes
Mar 25, 2026
6 tasks
yux0
approved these changes
Mar 25, 2026
Sushisource
reviewed
Apr 21, 2026
Comment on lines
+265
to
+266
| // instructions. If not set, the poll is routed randomly which can cause it being blocked | ||
| // without receiving a task while the queue actually has tasks in another server location. |
Member
There was a problem hiding this comment.
Suggested change
| // instructions. If not set, the poll is routed randomly which can cause it being blocked | |
| // without receiving a task while the queue actually has tasks in another server location. | |
| // instructions. If not set, the poll is routed randomly which can cause it to be blocked | |
| // without receiving a task while the queue actually has tasks in another server location. |
Wording fix needs to apply everywhere.
It'll be forwarded though, at some point right?
Contributor
Author
There was a problem hiding this comment.
forgot to apply the change before merge. will send it in my next PR.
It'll be forwarded though, at some point right?
No, there wont be any cross-poller-group forwards. The poll stays there until expired and next time it'll be routed randomly again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adding
poller-group-idandpoller-group-infofields to the poll APIs.Why?
SDK needs to pass poller group ID in some APIs according to server instructions.
Breaking changes
None
Server PR
No new API added.