Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomResourceDefinitions Do Not Have Metadata For "explain" response #582

Open
InfoSec812 opened this issue Jan 18, 2022 · 6 comments
Open
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@InfoSec812
Copy link

Expected Behavior

Given that the Tekton operator is installed on an OpenShift cluster
When I execute oc explain <TektonResource>
Then I expect to see information documenting the API and Resources

Actual Behavior

$ oc explain EventListener
KIND:     EventListener
VERSION:  triggers.tekton.dev/v1beta1

DESCRIPTION:
     <empty>

Steps to Reproduce the Problem

  1. Log on to an OpenShift cluster via CLI where Tekton is installed
  2. Run oc explain --recursive EventListener
  3. Note that there is no explanation

Additional Info

  • Kubernetes version:
❯ oc version
Client Version: v4.2.0-alpha.0-657-g51011e4
Server Version: 4.9.12
Kubernetes Version: v1.22.3+e790d7f
  • Tekton Pipeline version:
❯ tkn version
Client version: 0.21.0
Pipeline version: v0.28.2
Triggers version: v0.16.1
@InfoSec812 InfoSec812 added the kind/bug Categorizes issue or PR as related to a bug. label Jan 18, 2022
@InfoSec812
Copy link
Author

An example of a proper response would be:

❯ oc explain --recursive ConfigMap
KIND:     ConfigMap
VERSION:  v1

DESCRIPTION:
     ConfigMap holds configuration data for pods to consume.

FIELDS:
   apiVersion   <string>
   binaryData   <map[string]string>
   data <map[string]string>
   immutable    <boolean>
   kind <string>
   metadata     <Object>
      annotations       <map[string]string>
      clusterName       <string>
      creationTimestamp <string>
      deletionGracePeriodSeconds        <integer>
      deletionTimestamp <string>
      finalizers        <[]string>
      generateName      <string>
      generation        <integer>
      labels    <map[string]string>
      managedFields     <[]Object>
         apiVersion     <string>
         fieldsType     <string>
         fieldsV1       <map[string]>
         manager        <string>
         operation      <string>
         subresource    <string>
         time   <string>
      name      <string>
      namespace <string>
      ownerReferences   <[]Object>
         apiVersion     <string>
         blockOwnerDeletion     <boolean>
         controller     <boolean>
         kind   <string>
         name   <string>
         uid    <string>
      resourceVersion   <string>
      selfLink  <string>
      uid       <string>

@nikhil-thomas nikhil-thomas added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 19, 2022
@nikhil-thomas
Copy link
Member

+ 💯
This can definitely improve developer experience.

We shall try to work with the TektonCD community and get this in for CRDs coming from each indidual projects (TektonPipeline, TektonTriggers...).

To start with we shall try to do this for the CRD definitions in operaotor (eg: TektonConfig).

cc @vdemeester

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Jan 20, 2022

This PR: tektoncd/pipeline#1776 is a good reference on how to generate it automatically.
In addition, Knative is doing it already.

ref: https://github.com/knative/serving/blob/main/hack/update-schemas.sh

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2022
@InfoSec812
Copy link
Author

/remove-lifecycle stale

Issue is still awaiting a resolution

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2022
@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

4 participants