Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requeue and Retry Tektoncd Pipeline upgrade if there are active TaskRuns #561

Open
nikhil-thomas opened this issue Dec 13, 2021 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@nikhil-thomas
Copy link
Member

Feature request

The operator should make sure that there are no active TaskRuns before carrying out a Tektoncd Pipeline upgrade.

Use case

Internal changes in Tektoncd Pipeline could break active TaskRuns after an upgrade. For example: If we add/filtering of Pods in Pipelines controller, Pods created by an older version of Pipelines controller will not be visible to a newer Pipelines controller.

To ensure, that there are not unpleasant surprises (eg: TaskRun failure during a Pipeline Upgrade), we need to make sure that the operator waits and retries an upgrade if there are active TaskRuns.

Ref:

@nikhil-thomas nikhil-thomas added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 13, 2021
@nikhil-thomas
Copy link
Member Author

we can think of a more generic check, something like is_upgrade_ready() for each component (Pipelines, Triggers, Hub...) to make sure that necessary housekeeping tasks are carried out before the operator rollsout a component upgrade.

@nikhil-thomas nikhil-thomas added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 13, 2021
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2022
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 13, 2022
@vdemeester
Copy link
Member

/lifecycle frozen
Most likely something we still want to explore (or explicitely say we don't want to do it after some exploration)

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

3 participants