Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-registry-cert config map is erased when tekton operator pod restarts #1429

Open
lucienbanholzer opened this issue Apr 6, 2023 · 10 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lucienbanholzer
Copy link

lucienbanholzer commented Apr 6, 2023

Dear team,

In order to be able to pull images from our private registry I need to declare custom SSL certificates in configmap config-registry-cert.

The issue is when tekton-operator pod restarts this configmap resource is deleted (and a fresh one without my certificates is created).

I don't find any solution in tekton operator config to make it persistent.

Do you have a solution for this ?

Thanks a lot for your help,

BR

@lucienbanholzer
Copy link
Author

Any idea ?

@vdemeester
Copy link
Member

cc @jkandasa

This is "expected" behavior so far, as those configmap are managed by the operator. We probably need to add an option to configure this configmap from the operator 👼🏼

@jkandasa
Copy link
Member

I just checked the code and sadly we do not have an option to ignore it in the current design 🙁
On operator pod restarts installersets reconciles and revert back the resources into it is original state.

@jkandasa
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 14, 2023
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 13, 2023
@vdemeester
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 13, 2023
@vdemeester
Copy link
Member

@jkandasa could we remove it entirely from they payload and let users create it on demand ? I wonder if pipeline fails or not if the configmap doesn't exists.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2023
@vdemeester
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2023
@jkandasa
Copy link
Member

jkandasa commented Oct 12, 2023

@lucienbanholzer Now it is possible with additional field options: https://tekton.dev/vault/operator-main/tektonconfig/#additional-fields-as-options available from v0.68.0 release.

example:

apiVersion: operator.tekton.dev/v1alpha1
kind: TektonConfig
metadata:
  name: config
spec:
  pipeline:
    options:
      disabled: false
      configMaps:
        config-registry-cert:
          data:
            # your data

Can you please let me know, if something not clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants