catchment area not selected with "Select current path"

[urskaufmann]

Describe the bug
one of the missing feature is, that the user has no tool to select the catchment areas, that where connected to selected nodes. That's why I search for code in the current plugin. And I found in \python\plugins\teksi_wastewater\gui\twwprofiledockwidget.py some code, that looks like tww should select not only nodes, but also catchment areas when choosing the Select current path command. Line 173ff

But in line 173 is code that can not work, because it is from qgep.
catchment_areas_layer = TwwLayerManager.layer("od_catchment_area")
In qgep we had layers with od_*. !

It works, if I change this line to
catchment_areas_layer = TwwLayerManager.layer("catchment_area")

To Reproduce
Exact steps to reproduce the behavior:

• use the upstream network following tool
• click on "Select current path"
• no catchment area are selected

Desktop (please complete the following information):

• TWW version 2024.0.5
• QGIS Version 3.40.4
• OS Win 10

Little change to use the code, that already exists and to help me on my daily work.

The help would be bigger, if the user can select the nodes and catchment_areas starting with a selection of reaches (separat tool)

[cymed]

Thanks for pointing that out! Could you provide a pull request?

[ponceta]

For the future, we should ensure that layer names syntax or translations are not affecting actions or plugin.

[cymed]

Solved with #567