Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button update wastewater symbologies and labels #264

Open
sjib opened this issue Jun 20, 2024 · 9 comments
Open

Add button update wastewater symbologies and labels #264

sjib opened this issue Jun 20, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@sjib
Copy link
Contributor

sjib commented Jun 20, 2024

          These 2 lines did run obviously with the import 

SELECT tww_app.wastewater_structure_update_fk_main_cover('', True);
SELECT tww_app.wastewater_structure_update_fk_main_wastewater_node('', True);

These 3 lines did not run, but must run with the import:
SELECT tww_app.update_wastewater_node_symbology(NULL, True);
SELECT tww_app.update_wastewater_structure_label(NULL, True);
SELECT tww_app.update_wn_symbology_by_overflow(NULL, True);

And additionally: the user should be able to manualy run this lines whenever he wants. -> a new button or command in the ui to start this functions.

Originally posted by @urskaufmann in #260 (comment)

@sjib sjib added the enhancement New feature or request label Jun 20, 2024
@sjib
Copy link
Contributor Author

sjib commented Jun 20, 2024

Add code for new button to

and define new tool twwupdatewwssymbology.py in \wastewater\plugin\teksi_wastewater\tools

@sjib
Copy link
Contributor Author

sjib commented Jun 20, 2024

At all - are there any other requests for new buttons? Then please link to this issue.

@sjib
Copy link
Contributor Author

sjib commented Jun 20, 2024

These 3 lines did not run, but must run with the import:
SELECT tww_app.update_wastewater_node_symbology(NULL, True);
SELECT tww_app.update_wastewater_structure_label(NULL, True);
SELECT tww_app.update_wn_symbology_by_overflow(NULL, True);

Already added to import process - see #263

MIght have to be re-coded if new buttons exist.

@domi4484
Copy link
Contributor

@sjib SELECT tww_app.update_wn_symbology_by_overflow(NULL, True); this is already done inside update_wastewater_node_symbology. Is still needed to exec it again after update_wastewater_structure_label?

@sjib
Copy link
Contributor Author

sjib commented Jul 16, 2024

@domi4484 The idea is to create a new button "update wastewater symbologies and labels" in the plugin to be able to run these queries not only during the import process but anytime you want to update the symbology (as we can requery the network topology):

SELECT tww_app.update_wastewater_node_symbology(NULL, True);
SELECT tww_app.update_wastewater_structure_label(NULL, True);
SELECT tww_app.update_wn_symbology_by_overflow(NULL, True);

To all: Please vote with thumbs up if you think such a button is a necessary enhancement. Vote with thumb down if you think it is not necessary.

@domi4484
Copy link
Contributor

@sjib in the upper comment I meant that update_wn_symbology_by_overflow is already executed inside update_wastewater_node_symbology at this line:

EXECUTE tww_app.update_wn_symbology_by_overflow(_obj_id, _all);

It means the new button should execute only those queries i guess:

SELECT tww_app.update_wastewater_node_symbology(NULL, True);
SELECT tww_app.update_wastewater_structure_label(NULL, True);

@sjib
Copy link
Contributor Author

sjib commented Oct 3, 2024

@urskaufmann Is this solved with Pre-release 2024.0.2

@urskaufmann
Copy link
Contributor

Button exists, but I'm not sure, if they really work.
If I disable the triggers, then a calculation is faster. If I enable the triggers, the calculation is slower. But if I disable the triggers and then change the usage_current or the function_hierarchic of a reach, then the symbol of the manhole above changes also - and this calculation is done be the triggers? Or not?

So, how can I test the update symbology-button?

@urskaufmann
Copy link
Contributor

When changing a reachpoint.level, and the triggers are disabled, I can update the label of the manhole with the update button. Seems this works.

But: I run QGIS now twice in a not-responding-mode, while I did disable/enable the triggers several times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants