Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered Exports failing #154

Open
cymed opened this issue Feb 8, 2024 · 6 comments
Open

Filtered Exports failing #154

cymed opened this issue Feb 8, 2024 · 6 comments
Assignees
Labels
bug Something isn't working INTERLIS About INTERLIS exchange format (import / export) plugin Concerns the wastewater plugin

Comments

@cymed
Copy link
Contributor

cymed commented Feb 8, 2024

Filtered Exports might be failing if they include any classes hotfixed in #153

@3nids

This comment was marked as off-topic.

@3nids 3nids closed this as completed Feb 8, 2024
@cymed
Copy link
Contributor Author

cymed commented Feb 8, 2024

The problem I am referencing is that for most classes from VSA DSS, the query filter based on self.subset_ids is not set correctly. self.subset_ids contains the wastewater_networkelement, but all queries are structures as

query = query.filter(
                self.model_classes_tww_od.retention_body.obj_id.in_(self.subset_ids)
            )

, even though they do not share an obj_id with networkelement

@cymed cymed reopened this Feb 8, 2024
@ponceta ponceta added bug Something isn't working plugin Concerns the wastewater plugin INTERLIS About INTERLIS exchange format (import / export) labels Feb 13, 2024
@ponceta ponceta added this to the TEKSI Wastewater 2024.0 milestone Feb 13, 2024
@sjib
Copy link
Contributor

sjib commented May 4, 2024

@cymed So how would we have to set the filters? Would we need to follow the model hierarchy?

@cymed
Copy link
Contributor Author

cymed commented May 4, 2024

I think we need to cascade down from the subset oids to the specific oids using joins

@sjib
Copy link
Contributor

sjib commented May 15, 2024

rohrprofil_geometrie needs to be adapted also:
https://github.com/cymed/TEKSI-wastewater/blob/0c868c69f211cd1fc3f728e2c7c411656f3bbae2/plugin/teksi_wastewater/interlis/interlis_model_mapping/interlis_exporter_to_intermediate_schema.py#L1980

See adaptions on qgep in adding all classes to wastewater_networkelement into the join statement: QGEP/qgepqwat2ili#144 (comment)

@ponceta
Copy link
Member

ponceta commented Jun 12, 2024

sia debug port from QGEP FIX to TEKSI Wastewater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working INTERLIS About INTERLIS exchange format (import / export) plugin Concerns the wastewater plugin
Projects
None yet
Development

No branches or pull requests

4 participants