Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[further improvement] Add a compareTo method in MetricsReporter #8

Open
SidW opened this issue Jul 26, 2016 · 0 comments
Open

[further improvement] Add a compareTo method in MetricsReporter #8

SidW opened this issue Jul 26, 2016 · 0 comments

Comments

@SidW
Copy link
Contributor

SidW commented Jul 26, 2016

It might be better to move JmxReporter#prefix to MetricsReporter and add a compareTo method in MetricsReporter that returns true if (this.getClass == a.getClass) && this.prefix == a.prefix).

In that way, we could check if there is existing reporter before adding new reporter in MetricsRepository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SidW