Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped step detection with TMC2130 drivers #15

Open
teemuatlut opened this issue Dec 25, 2017 · 1 comment
Open

Skipped step detection with TMC2130 drivers #15

teemuatlut opened this issue Dec 25, 2017 · 1 comment

Comments

@teemuatlut
Copy link
Owner

@thinkyhead Hey I'm opening up a ticket here to have a quick discussion about how to implement this and I reckon you know the gcode handler/buffer better than anyone.

The skipped step detection has been requested a few times and was hinted towards on one Tom's videos. Prusa Research even has this implemented already.

So in order for us (me-too mentality) to have a similar feature for mainstream Marlin, I was thinking that the best way would be to utilize the endstops using interrupts feature. Basically if the interrupt is triggered when we are NOT homing an axis, then we inject a G28 XY command into the buffer as the very next command to execute.
I haven't yet looked at how to code this, so would you have any thoughts or suggestions regarding the implementation method?

@thinkyhead
Copy link

thinkyhead commented Feb 5, 2018

Hey, just found this as I was going through issues. They tend to pile up!

This feature definitely makes sense when using sensorless homing. It should be something we can turn on and off. It would replace the current behavior of the abort-on-endstop-hit feature with something a bit simpler, which is to re-home and resume instead of completely aborting the print.

Currently when we want to interrupt the G-code processing we do it by having a G-code handler go into a loop. For this it might make sense to add a pause flag to the G-code parser so it can stop processing G-code altogether while doing the re-home. That would allow the re-home to occur more quickly than if a G28 X Y was queued. The move back to the print position would be automatically done by the next G1 move processed, but only for Absolute (G90) mode. For a print job entirely done in relative mode it would be a little trickier.

The feature itself can probably be coded pretty easily!

teemuatlut pushed a commit that referenced this issue Oct 10, 2019
# This is the 1st commit message:

Add Support for ADIMLab Granty

# The commit message #2 will be skipped:

# Update Configuration.h

# The commit message #3 will be skipped:

# Add files via upload
#
# Add Support for ADIMLab Granty

# The commit message #4 will be skipped:

# Create Configuration.h

# The commit message #5 will be skipped:

# Delete Configuration.h

# The commit message #6 will be skipped:

# Create Test.h

# The commit message #7 will be skipped:

# Add files via upload

# The commit message #8 will be skipped:

# Delete Test.h

# The commit message #9 will be skipped:

# Delete Configuration.h

# The commit message #10 will be skipped:

# Delete Configuration_adv.h

# The commit message #11 will be skipped:

# Add files via upload
#
# Add ADIMLab Pins

# The commit message #12 will be skipped:

# Add files via upload
#
# Add Bootscreen

# The commit message #13 will be skipped:

# Update Configuration.h
#
# Add Bootscreen

# The commit message #14 will be skipped:

# Update pins.h
#
# Add ADIMLab Board

# The commit message #15 will be skipped:

# Update boards.h
#
# Add ADIMLab Granty

# The commit message #16 will be skipped:

# Update Makefile
#
# Add ADIMLab Granty

# The commit message #17 will be skipped:

# Update boards.h

# The commit message #18 will be skipped:

# Update Makefile
teemuatlut pushed a commit that referenced this issue Oct 10, 2019
* # This is a combination of 18 commits.
# This is the 1st commit message:

Add Support for ADIMLab Granty

# The commit message #2 will be skipped:

# Update Configuration.h

# The commit message #3 will be skipped:

# Add files via upload
#
# Add Support for ADIMLab Granty

# The commit message #4 will be skipped:

# Create Configuration.h

# The commit message #5 will be skipped:

# Delete Configuration.h

# The commit message #6 will be skipped:

# Create Test.h

# The commit message #7 will be skipped:

# Add files via upload

# The commit message #8 will be skipped:

# Delete Test.h

# The commit message #9 will be skipped:

# Delete Configuration.h

# The commit message #10 will be skipped:

# Delete Configuration_adv.h

# The commit message #11 will be skipped:

# Add files via upload
#
# Add ADIMLab Pins

# The commit message #12 will be skipped:

# Add files via upload
#
# Add Bootscreen

# The commit message #13 will be skipped:

# Update Configuration.h
#
# Add Bootscreen

# The commit message #14 will be skipped:

# Update pins.h
#
# Add ADIMLab Board

# The commit message #15 will be skipped:

# Update boards.h
#
# Add ADIMLab Granty

# The commit message #16 will be skipped:

# Update Makefile
#
# Add ADIMLab Granty

# The commit message #17 will be skipped:

# Update boards.h

# The commit message #18 will be skipped:

# Update Makefile

* Add Support for ADIMLab Granty

* Optimize bootscreen

* Update Makefile

Updated Description

* Update boards.h

Updated Description

* Update pins_HJC2560C_REV2.h

Updated Description

* Update Configuration.h

Added Author + Custom_Machine_Name

* Create _Bootscreen.h

Add Bootscreen

* Add files via upload

Add ADIMLab Granty v1

* Update boards.h

Add ADIMLab Granty v1

* Update Makefile

Add ADIMLab Granty v1

* Update pins_HJC2560C_REV2.h

* Consolidate Granty configs

* config updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants