Refresh metadata cache after failed package installation #3348
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajertom
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
Nov 8, 2024
happz
reviewed
Nov 8, 2024
happz
reviewed
Nov 8, 2024
happz
reviewed
Nov 8, 2024
bajertom
force-pushed
the
tbajer-dnf-cache-error
branch
2 times, most recently
from
c736cd9
to
793ac8a
Compare
happz
added
area | package managers
happz
reviewed
Nov 19, 2024
tmt/steps/prepare/install.py
Outdated
| except Exception: | ||
| # Refresh cache in case of recent but not updated change do repodata | ||
| self.guest.package_manager.refresh_metadata() | ||
| self._install() |
There was a problem hiding this comment.
I wonder whether should capture the first exception as well - this way, the original one is lost, with all its data. How about something like this?
try:
self._install()
except Exception as exc1:
# We do not have any special handling for exceptions raised by the following code.
# Wrapping them with try/except gives us a chance to attach the original exception
# to whatever the code may raise, and therefore preserve the information attached
# to the original exception.
try:
# Refresh cache in case of recent but not updated change do repodata
self.guest.package_manager.refresh_metadata()
self._install()
except Exception as exc2:
raise exc2 from ex1There was a problem hiding this comment.
You're right, that seems like an unnecessary loss of data - better to catch them both. I used your code, if that's alright:)
|
/packit test |
KwisatzHaderach
approved these changes
Nov 22, 2024
happz
force-pushed
the
tbajer-dnf-cache-error
branch
from
9c21ff0
to
a998cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3277
When testing I found out that there is different behavior in dnf5 compared to dnf4, where a mere
dnf makecachewould be enough, but dnf5 needs the --refresh option as well (ordnf clean metadataordnf clean expire-cache), see https://bugzilla.redhat.com/show_bug.cgi?id=2324177Not sure about the Exception being too generic. Should I create a new one, something like InstallationError? And notify the user through logger as to why
metadata --refreshis happening?Pull Request Checklist