Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not support passing props to Popper component #81

Open
liampcollins opened this issue Jul 1, 2019 · 2 comments
Open

Does not support passing props to Popper component #81

liampcollins opened this issue Jul 1, 2019 · 2 comments

Comments

@liampcollins
Copy link

Hi, I've a use case where I need to pass a prop to the Popper component. Could we update the library to support this, perhaps using something like getPopperProps in the same way that getInfiniteLoaderProps is implemented? Happy to do the PR if you think its a change worth making.

Thanks
@liampcollins liampcollins changed the title Does not support padding props to Popper component Does not support passing props to Popper component Jul 1, 2019
@techniq
Copy link
Owner

techniq commented Jul 1, 2019

@liampcollins That sounds good and a PR is most welcome. I haven't had much time for the project lately and hoping someone gets the v4 support finished.

@liampcollins
Copy link
Author

Hi @techniq , I've submitted a PR for this. Whenever you get a chance could you take a look please? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@techniq @liampcollins