Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it context aware #59

Open
6543 opened this issue Jul 16, 2024 · 2 comments
Open

Make it context aware #59

6543 opened this issue Jul 16, 2024 · 2 comments

Comments

@6543
Copy link

6543 commented Jul 16, 2024

It would be nice to have the option to pass an context into it, witch if canceled either rollback or stop at the next posible position.

In the best case the migrations itselve can decide what to do on context cancel like if it's a bulck migration of data, it stops after a bulck was done and if you restart the migration it starts where it ended. or if it's something atomic either rolback or finish ... and then end

else if context is not canceled we just progress as it is done now

@techknowlogick
Copy link
Owner

This sounds reasonable, and enough of a benefit that it would be a good reason to even be a breaking change (with the release of a v2).

Downstreams would have to be notified if this change is made (ping @kolaente)

@kolaente
Copy link
Contributor

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants