Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace domain by IP filter for tokens #19

Closed
eshiol opened this issue Apr 19, 2016 · 3 comments
Closed

Replace domain by IP filter for tokens #19

eshiol opened this issue Apr 19, 2016 · 3 comments

Comments

@eshiol
Copy link
Contributor

eshiol commented Apr 19, 2016

If you set the domain field for an api key, you can call a function with any domain, even empty domain.
@coolbung
Copy link
Member

I'd vote to remove the domain feature itself, I dont think it makes sense anymore. We should rather add a configuration that lets a user specify the IP addresses that an API key can be used from.

@eshiol
Copy link
Contributor Author

eshiol commented Apr 25, 2016

I agree.

@coolbung coolbung changed the title Domain filter doesn't work Replace domain by IP filter for tokens Jul 28, 2017
@coolbung
Copy link
Member

coolbung commented Oct 2, 2017

Added #62 for IP based restriction. Closing this.

@coolbung coolbung closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coolbung @eshiol