Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parts of codebase more elixir'y #12

Open
techgaun opened this issue Mar 22, 2019 · 2 comments
Open

Make parts of codebase more elixir'y #12

techgaun opened this issue Mar 22, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@techgaun
Copy link
Owner

There are parts of codes that would benefit from more Elixir style coding. This issue will serve as a ground for future PRs and commits for improving codebase quality

@techgaun techgaun added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Mar 22, 2019
@axelson
Copy link
Contributor

axelson commented Mar 31, 2019

Did you have any parts in mind?

@techgaun
Copy link
Owner Author

techgaun commented Mar 31, 2019

@axelson ya like
https://github.com/techgaun/zxcvbn-elixir/blob/master/lib/zxcvbn/matching.ex#L358-L494
https://github.com/techgaun/zxcvbn-elixir/blob/master/lib/zxcvbn/scoring.ex#L142-L169

There're few places where I got anonymous functions within function body. I would prefer to extract them out to their own functions. Also, this one: #7 would be good to work on

Also, input from community would be good as feedback so this can get better in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants