Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ALL Events [IMPORTANT] #50

Open
jasonkalmeida opened this issue Nov 19, 2019 · 3 comments
Open

Get ALL Events [IMPORTANT] #50

jasonkalmeida opened this issue Nov 19, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jasonkalmeida
Copy link
Collaborator

So, upon testing, I realized that my initial code base failed to do a very basic thing - get ALL events.

The current map only shows the events in the initial response - in the response there is a next attribute that offers the next pagination.

This feature should modify the original effect hook to get all the events and append them into a JSON object that will then be set to state.

Additionally, with the new search area limit feature, this won't lead to getting the whole country.


I can see how this might potentially impact other features, so whoever takes this up please make sure to have it live on a personal Github Page so we can test it thoroughly!

@jasonkalmeida jasonkalmeida added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2019
@joziesands
Copy link
Contributor

I'll take a run at this one.

@joegoldbeck
Copy link

@jasonkalmeida @joziesands is this closed by #52 ?

@joegoldbeck joegoldbeck removed the help wanted Extra attention is needed label Dec 13, 2019
@jasonkalmeida
Copy link
Collaborator Author

@joegoldbeck mitigated but not closed - #52 fixed it for most regions but there are high density areas in Iowa that will still miss some events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants