Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Marker - On Click #3

Open
jasonkalmeida opened this issue Aug 16, 2019 · 2 comments
Open

Location Marker - On Click #3

jasonkalmeida opened this issue Aug 16, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jasonkalmeida
Copy link
Collaborator

When a location marker is clicked:

  • The Event List should filter events that are only at that location (potentially in date order)
  • The Event List title should be changed to indicate the user is currently looking at "Events At X Location Name"

Note: I'm interested in tackling this feature after I finish the event list/cards feature, but just wanted to put this up here

@jasonkalmeida jasonkalmeida added the enhancement New feature or request label Aug 16, 2019
@jasonkalmeida jasonkalmeida self-assigned this Aug 29, 2019
@jasonkalmeida
Copy link
Collaborator Author

Basic location filter was added with the following commit: 707a753

Next Steps:

  • Point 2 in the OP, which is creating a more clear indicator that the list is currently filtered (right now marker is highlighted)

@chief-dweeb
Copy link
Collaborator

@jasonkalmeida - the code in EventList.js seems to filter events by latitude and longitude which seems great, except I fear that lat/long may be too precise. Use zip code 02140 and look at the events at Porter Square Books - there are two pins and if you zoom in they appear to be at oh-so-slightly different lat longs. Clicking on one or the other of them does not result in both of them being shown in the list of cards on the left. This may be an edge case not worth bothering about, but I thought I would bring it to your attention.

chief-dweeb added a commit that referenced this issue Jan 22, 2020
Merge out from techforwarren to my fork's master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants