Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort events by relative distance vs which is soonest #11

Open
john-osullivan opened this issue Sep 7, 2019 · 3 comments
Open

Sort events by relative distance vs which is soonest #11

john-osullivan opened this issue Sep 7, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@john-osullivan
Copy link
Contributor

Simple and straightforward enhancement that came to mind when testing the fix for all those times!

@john-osullivan john-osullivan added the enhancement New feature or request label Sep 7, 2019
@jasonkalmeida
Copy link
Collaborator

Hey @john-osullivan, would you be interested in taking this feature on logic wise (I can help out with ? I'm thinking of renaming it as a general Sort feature as follows.

Sort Feature

As of now, the event list sorts by distance to the zip code. While this is definitely useful, and probably what we want the default sort to be, we should provide users additional functionality on this front:

  • Sort by distance (current and default)
  • Sort by time
  • The ability to switch between the two in their current search result

Any other sorting ideas? Off of the top of my head, I guess one potential sort is "popularity" or "key events" (i.e. events that have Senator Warren or other high profile guests). Even if we go with just the above 2 for now, this will probably involve introducing a new "sort" state variable that we'll manipulate and reset upon new searches.

@danielnarey
Copy link

I’m not sure that this enhancement is necessary for an initial release - the user can determine proximity from the map and click/tap on markers to get event info.

@chief-dweeb
Copy link
Collaborator

Sorting by time will complicate the logic elsewhere for combining all of the events at a given location into the list of cards. Imagine a list sorted by time that contains events that happen at many times at a given location. The first UX issue is whether you sort by time of day or just day. If you sort by time of day then you run the risk of having back-to-back-to-back phone banks having a separate card for each and every time slot. You then have the issue of clicking on a pin/marker on the map - what should happen? Currently the list of cards changes to just being the events at that location - should it now be the events at that location ordered by time?

My gut instinct is to put this RFE into a general bucket of all search criteria enhancements and to then think a little more broadly about UX. I can think of all sorts of ways I might want to filter what is returned: by date, by kind of event (canvassing vs. watch party, etc.), by location (zip code, city, state), by whether local or remote (and if remote whether a bus is provided), etc. Adding each of these in succession might work but before we go down that path, why not think about whether we want a more general UX approach (for example, a button labeled "Other Search Options" in the current ZIP entry box)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants