Skip to content

Commit 5e5750d

Browse files
authored
Merge pull request #2 from techdivision/neos-5x
WIP: Support neos 5.x
2 parents c1c123d + 599878b commit 5e5750d

File tree

6 files changed

+34
-16
lines changed

6 files changed

+34
-16
lines changed

Classes/TechDivision/DocViewer/AccessManager.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
namespace TechDivision\DocViewer;
33

44
use Neos\Flow\Annotations as Flow;
5+
use Neos\Flow\Package\PackageInterface;
56
use Neos\Neos\Controller\Module\AbstractModuleController;
67

78
/**
@@ -20,7 +21,7 @@ class AccessManager extends AbstractModuleController
2021

2122
/**
2223
* @Flow\Inject
23-
* @var \Neos\Flow\Package\PackageManagerInterface
24+
* @var \Neos\Flow\Package\PackageManager
2425
*/
2526
protected $packageManager;
2627

@@ -31,10 +32,9 @@ class AccessManager extends AbstractModuleController
3132
* @return bool
3233
*/
3334
public function isPackageAccessable($packageKey) {
34-
return $this->packageManager->isPackageActive($packageKey) &&
35-
(!array_key_exists($packageKey, $this->packagesConfiguration['hide']) ||
36-
!$this->packagesConfiguration['hide'][$packageKey]
37-
);
35+
36+
$packages = $this->packageManager->getAvailablePackages();
37+
return isset($packages[$packageKey]);
3838
}
3939

4040
}

Classes/TechDivision/DocViewer/Controller/ModuleController.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class ModuleController extends AbstractModuleController
2020

2121
/**
2222
* @Flow\Inject
23-
* @var \Neos\Flow\Package\PackageManagerInterface
23+
* @var \Neos\Flow\Package\PackageManager
2424
*/
2525
protected $packageManager;
2626

@@ -74,7 +74,7 @@ public function listAction() {
7474
continue;
7575
}
7676

77-
$tree = new Tree($package, $this->controllerContext->getRequest()->getHttpRequest()->getBaseUri());
77+
$tree = new Tree($package, $this->controllerContext->getRequest()->getHttpRequest()->getUri());
7878

7979
if(!$tree->isDirectoryWithContent()) {
8080
continue;
@@ -103,7 +103,7 @@ public function listAction() {
103103
* @return void
104104
*/
105105
public function showAction($package, $filePath = null) {
106-
$baseUri = $this->controllerContext->getRequest()->getHttpRequest()->getBaseUri();
106+
$baseUri = $this->controllerContext->getRequest()->getHttpRequest()->getUri();
107107

108108
if (!$this->accessManager->isPackageAccessable($package)) {
109109
throw new PackageNotAccessibleException("You are not allowed to access the package " . $package);

Classes/TechDivision/DocViewer/Controller/ResourceController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class ResourceController extends \Neos\Flow\Mvc\Controller\ActionController
2727

2828
/**
2929
* @Flow\Inject
30-
* @var \Neos\Flow\Package\PackageManagerInterface
30+
* @var \Neos\Flow\Package\PackageManager
3131
*/
3232
protected $packageManager;
3333

Classes/TechDivision/DocViewer/File/Node.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,12 @@ public function setIsParseable($isParseable)
175175
*/
176176
public function getPackageKey()
177177
{
178-
return $this->package->getPackageKey();
178+
// very dirty workaround, refactoring soon
179+
if(is_string($this->package)) {
180+
return $this->package;
181+
}else {
182+
return $this->package->getPackageKey();
183+
}
179184
}
180185

181186
}

Classes/TechDivision/DocViewer/ViewHelpers/ResourceUrlViewHelper.php

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,30 @@ class ResourceUrlViewHelper extends AbstractViewHelper
1313
{
1414
/**
1515
* @Flow\Inject
16-
* @var \Neos\Flow\Package\PackageManagerInterface
16+
* @var \Neos\Flow\Package\PackageManager
1717
*/
1818
protected $packageManager;
1919

2020
/**
21-
* @param string $package
22-
* @param string $filePath
21+
* Initialize the arguments.
22+
*
23+
* @return void
24+
* @api
25+
*/
26+
public function initializeArguments()
27+
{
28+
$this->registerArgument('package', 'string', 'Package key for the resource', false, null);
29+
$this->registerArgument('filePath', 'string', 'File path for the resource', false, null);
30+
}
31+
32+
/**
2333
* @return string
2434
*/
25-
public function render($package, $filePath)
35+
public function render()
2636
{
27-
return Util::buildResourceUrl(new Node($this->packageManager->getPackage($package), $filePath), null, $this->controllerContext->getRequest()->getHttpRequest()->getBaseUri());
37+
38+
$package = $this->arguments['package'];
39+
$filePath = $this->arguments['filePath'];
40+
return Util::buildResourceUrl(new Node($this->packageManager->getPackage($package), $filePath), null, $this->controllerContext->getRequest()->getHttpRequest()->getUri());
2841
}
2942
}

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
],
1717
"license": "GPL-3.0+",
1818
"require": {
19-
"neos/neos": "^3.0",
19+
"neos/neos": "^5.0",
2020
"erusev/parsedown": "1.6.*"
2121
},
2222
"autoload": {

0 commit comments

Comments
 (0)