Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol method return type hints can't be primitive #409

Open
puredanger opened this issue Jun 4, 2024 · 1 comment
Open

Protocol method return type hints can't be primitive #409

puredanger opened this issue Jun 4, 2024 · 1 comment

Comments

@puredanger
Copy link

As we were working on this issue https://clojure.atlassian.net/browse/CLJ-2698, we were looking in the world for cases of defprotocol methods with ^double and ^long return type hints (which are not valid - protocol methods always return Object) and found PRowCount and PColumnCount in tech.v3.dataset.protocols - I would recommend removing those type hints as they are not valid. But FYI, I am not expecting any change in behavior in Clojure in 1.12.

@harold
Copy link
Contributor

harold commented Jun 4, 2024

👍 Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants