New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistency between printed shape and `shape` function #407

Open

behrica opened this issue Apr 27, 2024 · 1 comment

Contributor

behrica commented Apr 27, 2024

It at least surprised me to see that the shape is flipped when printing the dataset:

tech.ml.dataset/src/tech/v3/dataset/print.clj

Line 336 in b0896cc

(vec (reverse (dtype/shape ds)))))]

so I report it here.

Collaborator

cnuernber commented May 17, 2024

dtype-next is row-major. All dataset libraries I tested output their shape in column-major form. This is why the reverse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment