Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CyanogenMod/android_packages_apps_CMFileManager
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cm-14.1
Choose a base ref
...
head repository: teamacid/android_packages_apps_CMFileManager
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ics
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.

Commits on Nov 10, 2012

  1. Initial API Level 14 (ICS) port

    Mike C committed Nov 10, 2012
    Copy the full SHA
    a209dd3 View commit details

Commits on Nov 13, 2012

  1. Copy the full SHA
    24cb66c View commit details
  2. Fixup for API 14 compatibility

    Mike C committed Nov 13, 2012
    Copy the full SHA
    3beefb5 View commit details

Commits on Nov 17, 2012

  1. CMFileManager: AOSP GET_CONTENT_DATA compatibility

    This change brings compatibility to GET_CONTENT_DATA for AOSP apps when
    using the PickerActivity:
    
    * Detect crop extra; use the com.android.camera.action.CROP action of Gallery3d
    to crop and return the requested image. This gets compatilibity for example with
    the contacts app, when a user try to set the image of a contact.
    * Detect android.provider.MediaStore.Audio.Media.EXTRA_MAX_BYTES; when this extra
    is present the PickerActivity only display (and allow select) files with a size lower
    than requested.
    * Detect Intent.EXTRA_LOCAL_ONLY; useless until CMFM allow access remote file systems.
    
    Change-Id: I1020458505b236653e869ec1c1f532dd6d686633
    jruesga committed Nov 17, 2012
    Copy the full SHA
    3183792 View commit details

Commits on Nov 18, 2012

  1. Issue 6606: CM File Manager will not Remember Selection for "Open Wit…

    …h" menu
    
    Issue: http://code.google.com/p/cyanogenmod/issues/detail?id=6606
    
    This patch makes the next changes:
    
    * Make the internal editor exportable. Now it can be treated as another activity and can be mark
      as preferred activity, but only for text/* and some text mime/types. For undefined mime/types
      categories, the internal editor is still used in a non preferred mode (internal editor cannot
      be marked as preferred)
    * When the internal editor in a non preferred mode is selected, 'remember' checkbox is hidden.
    * Improve preferred activity resolution
    * Allow clear a preferred activity on the open with dialog (when 'remember' checkbox is unchecked)
    * For better compatibility, the internal editor now ignores the ACTION_EDIT action, so opened
      files are always editables (with the exception of binary files that they are opened always as
      read-only)
    * Improved onIntentSelected with better NPE and internal editor checks
    
    Change-Id: Ie42990a6c0ccbdd4bfab6ec23ae27cc808cac7b7
    jruesga committed Nov 18, 2012
    Copy the full SHA
    2fa90d2 View commit details

Commits on Nov 19, 2012

  1. Update Hungarian translations

    Change-Id: Iaccfae69ced0570d61661858d8803d0630826fd8
    tothtamassyman committed Nov 19, 2012
    Copy the full SHA
    3a27619 View commit details
  2. Merge remote-tracking branch 'upstream/jellybean' into ics

    Conflicts:
    	src/com/cyanogenmod/filemanager/ui/dialogs/FilesystemInfoDialog.java
    Mike C committed Nov 19, 2012
    Copy the full SHA
    6757d07 View commit details
  3. Fixups for CM9 / ICS

    Mike C committed Nov 19, 2012
    Copy the full SHA
    24d5db5 View commit details
  4. Copy the full SHA
    938cb2f View commit details
  5. Merge "CMFileManager: AOSP GET_CONTENT_DATA compatibility" into jelly…

    …bean
    jruesga authored and Gerrit Code Review committed Nov 19, 2012
    Copy the full SHA
    da9e86a View commit details
  6. Merge "Issue 6606: CM File Manager will not Remember Selection for "O…

    …pen With" menu" into jellybean
    jruesga authored and Gerrit Code Review committed Nov 19, 2012
    Copy the full SHA
    dda3873 View commit details
  7. Merge "Update Hungarian translations" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 19, 2012
    Copy the full SHA
    02f052f View commit details
  8. CMFileManager: Add Greek translation

    Patchset 2: Remove untranslatable strings
    
    Patchset 3: Add missing themes translation
    
    Change-Id: Ica0afe84cdd9fac9c243c817eb407a5d098e2410
    mikeNG committed Nov 19, 2012
    Copy the full SHA
    c3eb79f View commit details
  9. CMFileManager: Fix ReadCommand incompatible buffer

    Replace Reader buffer for InputStream buffer for avoid incomplatible char[] -> byte[] conversion.
    
    Change-Id: Ic916f55e5b0be96d1b4ffef36ddd5d5858ea3fdc
    jruesga committed Nov 19, 2012
    Copy the full SHA
    463b0da View commit details
  10. CMFileManager: Check shell commands on startup

    This change improved the detection of CM rooted devices with support for all the
    commands used by CMFM. In case of one of this command was not detected, the app start
    in chrooted-java mode (with limited support).
    
    Change-Id: Ie0f61d74f9619f476ea517c1b3c03ec453e033f3
    jruesga committed Nov 19, 2012
    Copy the full SHA
    dc4416c View commit details

Commits on Nov 21, 2012

  1. CMFileManager: updated romanian translation

    Change-Id: Ie230346ac607626432a41bcc36ad445ac16da520
    Signed-off-by: igoriok <igor_sorocean@hotmail.com>
    ygorigor committed Nov 21, 2012
    Copy the full SHA
    bbf9e4b View commit details

Commits on Nov 22, 2012

  1. Merge "CMFileManager: updated romanian translation" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 22, 2012
    Copy the full SHA
    6739d6e View commit details
  2. Merge "CMFileManager: Add Greek translation" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 22, 2012
    Copy the full SHA
    088a679 View commit details
  3. CMFileManager: Escape $ on prepared arguments

    Escape $ character when passing arguments to shell. xe: create new file with  name "$My Documents"
    
    Change-Id: I939d830beaa4c372aa679f3d27f7c691a29c421e
    jruesga committed Nov 22, 2012
    Copy the full SHA
    4ab0701 View commit details

Commits on Nov 23, 2012

  1. Copy the full SHA
    6e6ea76 View commit details
  2. Copy the full SHA
    508ca2b View commit details
  3. Comment out unknown lint stuff

    Mike C committed Nov 23, 2012
    Copy the full SHA
    a9b24b5 View commit details

Commits on Nov 24, 2012

  1. CMFileManager: Add Japanese translation

     - Initial Japanese translation for FileManager.
     - patch-2: Add translation for theme.
     - patch-3: Revised translation for theme.
    
    Change-Id: Ie234334b2c09e2093976410046bdc990acd8ad9d
    takuo committed Nov 24, 2012
    Copy the full SHA
    e12b204 View commit details
  2. Merge "CMFileManager: Check shell commands on startup" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 24, 2012
    Copy the full SHA
    4ac8d65 View commit details
  3. CMFileManager: Formatting

    Change-Id: Ia3e72bdad1882afbb151d2f04340a1af88c20682
    jruesga committed Nov 24, 2012
    Copy the full SHA
    fe8cd27 View commit details
  4. Merge "CMFileManager: Formatting" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 24, 2012
    Copy the full SHA
    59ff578 View commit details
  5. CMFileManager: PickerActivity: debug requested paremeters

    Add requested parameters to logcat for better debugging.
    
    Change-Id: I52e362ca8ad4b3687b78ee92e18e3015a6e645e0
    jruesga committed Nov 24, 2012
    Copy the full SHA
    e39313f View commit details
  6. CMFileManager: Compress type selection dialog has an invalid background

    The background dialog for selecting the compression type has an invalid color.
    The valid color is the background color of the dialog.
    
    Change-Id: Ib5ecf1c59e5c99ccd6ed8707646b718ca88dbcd9
    jruesga committed Nov 24, 2012
    Copy the full SHA
    9f41124 View commit details
  7. CMFileManager: Fix quickfoldersearch command for files with whitespaces

    This change fixed the quickfoldersearch command used by InlineAutocompleteTextView
    widget, when retrieve items with some whitespace in its name.
    Replace awk by cut command, and redirect stderr output of ls to /dev/null.
    
    Change-Id: Id039e573dc5e6ae5755b3251f014f34cd104f426
    jruesga committed Nov 24, 2012
    Copy the full SHA
    ea95876 View commit details
  8. Merge "CMFileManager: Fix quickfoldersearch command for files with wh…

    …itespaces" into jellybean
    DvTonder authored and Gerrit Code Review committed Nov 24, 2012
    Copy the full SHA
    626865c View commit details

Commits on Nov 25, 2012

  1. Merge "CMFileManager: Add Japanese translation" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 25, 2012
    Copy the full SHA
    79c2a3b View commit details
  2. Issue 6722: CM File Manager can not Play/Start files recorded with CM…

    … embedded Soundrekorder
    
    Issue: http://code.google.com/p/cyanogenmod/issues/detail?id=6722
    
    Updated "video/3gpp" and "video/3gpp2" mime/types extensions
    
    Change-Id: I5c04a582ea5f961dd6387602613d5b2248a9ff5e
    jruesga committed Nov 25, 2012
    Copy the full SHA
    77fafd9 View commit details

Commits on Nov 27, 2012

  1. CMFileManager: pt-pt translations

    Patchset 1: initial translations
    Patchset 2: dark theme translation
    
    Change-Id: I3e2873f4574207eddfe5666180521d79a1c19e34
    joaoventura committed Nov 27, 2012
    Copy the full SHA
    61ced4b View commit details
  2. Issue 6743: CM FileManager can't recognize file types if named with c…

    …apital suffix
    
    Issue: http://code.google.com/p/cyanogenmod/issues/detail?id=6743
    
    Added case compare to extension and mime/types.
    
    Change-Id: I394472e03b5a92590088fdebbb75dd13ee4bade2
    jruesga committed Nov 27, 2012
    Copy the full SHA
    fa69140 View commit details

Commits on Nov 28, 2012

  1. PT-BR: Added missing translations + Issue 6676 fix

    Change-Id: I3ddefe0ef5c71314f17845df0db4a3fa022e6ec2
    Gustav0ar committed Nov 28, 2012
    Copy the full SHA
    c056447 View commit details

Commits on Nov 29, 2012

  1. Merge "PT-BR: Added missing translations + Issue 6676 fix" into jelly…

    …bean
    jruesga authored and Gerrit Code Review committed Nov 29, 2012
    Copy the full SHA
    534ee2e View commit details
  2. Merge "CMFileManager: pt-pt translations" into jellybean

    jruesga authored and Gerrit Code Review committed Nov 29, 2012
    Copy the full SHA
    74db77f View commit details

Commits on Nov 30, 2012

  1. Copy the full SHA
    d243317 View commit details

Commits on Dec 3, 2012

  1. updated italian translation

    Change-Id: Ia788ea90c7841803b587a0892c17da2fa6c4ef18
    Kali- committed Dec 3, 2012
    Copy the full SHA
    592f6fd View commit details
  2. Issue 6769: The bottom bar of pop-up boxes in CM File Manager should …

    …be “Done” or “OK” rather than “Cancel”
    
    Issue: http://code.google.com/p/cyanogenmod/issues/detail?id=6769
    
    Changed "Cancel" to "Ok" in FsoPropertiesDialog and FilesystemInfoDialog.
    
    Change-Id: Id92ea897afae69e059da661a13350bc7020509c4
    jruesga committed Dec 3, 2012
    Copy the full SHA
    5730cd8 View commit details

Commits on Dec 5, 2012

  1. Merge "updated italian translation" into jellybean

    jruesga authored and Gerrit Code Review committed Dec 5, 2012
    Copy the full SHA
    63d1e03 View commit details
  2. Issue 6795: File Manager selected file actions vanish on navigation t…

    …o parent directory
    
    Issue: http://code.google.com/p/cyanogenmod/issues/detail?id=6795
    
    The issue is relate to back navigation (nor to ahead navigation). In this case the history
    parcelable info data is recovery (which has a invalid selection data).
    On back navigation, replace the selection data parcelable info with the current selection
    of the navigation view.
    Added notifyDataSetChanged() when toogle visibility, needed to refresh the view and repaint
    the items.
    
    Change-Id: Ib281c6fbc33274f6e81cc6b588cde420d6ceb19f
    jruesga committed Dec 5, 2012
    Copy the full SHA
    f10777b View commit details

Commits on Dec 6, 2012

  1. Copy the full SHA
    a0ec2b4 View commit details

Commits on Dec 11, 2012

  1. CMFileManager: Fix Typo

    Change-Id: I0a52f9abede317d3beeac9937052d92c53972edd
    invisiblek committed Dec 11, 2012
    Copy the full SHA
    64aa1f4 View commit details

Commits on Dec 12, 2012

  1. Copy the full SHA
    d7460f8 View commit details

Commits on Dec 16, 2012

  1. CMFileManager: Make groups command optional

    Groups command command is causing problems on some implementations (maybe toolbox?)
    which don't recognize the root AID and returns an error, and avoid to get root access.
    
    Patchset 2: Fix typo
    
    Change-Id: Idc17b18c34b8be263a1739dbad2921f60101fa09
    jruesga committed Dec 16, 2012
    Copy the full SHA
    995e39a View commit details

Commits on Dec 17, 2012

  1. Copy the full SHA
    e2c06b2 View commit details

Commits on Dec 26, 2012

  1. Merge remote-tracking branch 'upstream/cm-10.1' into ics

    Conflicts:
    	AndroidManifest.xml
    	src/com/cyanogenmod/filemanager/util/FileHelper.java
    	tests/AndroidManifest.xml
    	themes/AndroidManifest.xml
    	themes/res/values-pt-rBR/strings.xml
    Mike C committed Dec 26, 2012
    Copy the full SHA
    625d43a View commit details

Commits on Jan 7, 2013

  1. Merge remote-tracking branch 'upstream/cm-10.1' into ics

    Conflicts:
    	src/com/cyanogenmod/filemanager/util/FileHelper.java
    Mike C committed Jan 7, 2013
    Copy the full SHA
    9610d1c View commit details

Commits on Jan 10, 2013

  1. Copy the full SHA
    db195c4 View commit details
3 changes: 2 additions & 1 deletion AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -21,7 +21,8 @@

<original-package android:name="com.cyanogenmod.filemanager" />

<uses-sdk android:minSdkVersion="17" android:targetSdkVersion="17" />
<!-- Updated to be 14 for CM9 / ICS compatibility -->
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="14" />

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.MOUNT_UNMOUNT_FILESYSTEMS" />
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package afzkl.development.mColorPicker.views;

import java.util.concurrent.atomic.AtomicInteger;

/*
* Fill in API Level 17 gaps that are in use in CMFileManager
*/
public class APILevel17 {

private static final AtomicInteger sNextGeneratedId = new AtomicInteger(1);

/**
* Generate a value suitable for use in {@link #setId(int)}.
* This value will not collide with ID values generated at build time by aapt for R.id.
*
* @return a generated ID value
*/
public static int generateViewId() {
for (;;) {
final int result = sNextGeneratedId.get();
// aapt-generated IDs have the high byte nonzero; clamp to the range under that.
int newValue = result + 1;
if (newValue > 0x00FFFFFF) newValue = 1; // Roll over to 1, not 0.
if (sNextGeneratedId.compareAndSet(result, newValue)) {
return result;
}
}
}

}
Original file line number Diff line number Diff line change
@@ -111,7 +111,7 @@ private void init() {
// Create the scrollview over the dialog
final int dlgMarging = (int)convertDpToPixel(DEFAULT_MARGIN_DP);
ScrollView sv = new ScrollView(getContext());
sv.setId(generateViewId());
sv.setId(APILevel17.generateViewId());
RelativeLayout.LayoutParams lp = new RelativeLayout.LayoutParams(
android.view.ViewGroup.LayoutParams.MATCH_PARENT,
android.view.ViewGroup.LayoutParams.WRAP_CONTENT);
@@ -121,7 +121,7 @@ private void init() {

// Now the vertical layout
LinearLayout ll = new LinearLayout(getContext());
ll.setId(generateViewId());
ll.setId(APILevel17.generateViewId());
lp = new RelativeLayout.LayoutParams(
android.view.ViewGroup.LayoutParams.MATCH_PARENT,
android.view.ViewGroup.LayoutParams.MATCH_PARENT);
@@ -199,7 +199,7 @@ public CharSequence filter(CharSequence source, int start,
this.etColor.addTextChangedListener(this);

LinearLayout ll1 = new LinearLayout(getContext());
ll1.setId(generateViewId());
ll1.setId(APILevel17.generateViewId());
RelativeLayout.LayoutParams lp = new RelativeLayout.LayoutParams(
android.view.ViewGroup.LayoutParams.MATCH_PARENT,
android.view.ViewGroup.LayoutParams.WRAP_CONTENT);
@@ -223,7 +223,7 @@ public CharSequence filter(CharSequence source, int start,
private int createColorPicker(ViewGroup parent, int belowOf) {
final int dlgMarging = (int)convertDpToPixel(DEFAULT_MARGIN_DP);
this.mPickerView = new ColorPickerView(getContext());
this.mPickerView.setId(generateViewId());
this.mPickerView.setId(APILevel17.generateViewId());
this.mPickerView.setOnColorChangedListener(this);
RelativeLayout.LayoutParams lp = new RelativeLayout.LayoutParams(
android.view.ViewGroup.LayoutParams.MATCH_PARENT,
@@ -274,7 +274,7 @@ private int createColorsPanel(ViewGroup parent, int belowOf) {
sep1.setTextSize(TypedValue.COMPLEX_UNIT_SP, DEFAULT_TEXT_SIZE_SP);

LinearLayout ll1 = new LinearLayout(getContext());
ll1.setId(generateViewId());
ll1.setId(APILevel17.generateViewId());
RelativeLayout.LayoutParams lp = new RelativeLayout.LayoutParams(
android.view.ViewGroup.LayoutParams.MATCH_PARENT,
android.view.ViewGroup.LayoutParams.WRAP_CONTENT);
@@ -306,7 +306,7 @@ private int createColorsPanel(ViewGroup parent, int belowOf) {
sep2.setTextSize(TypedValue.COMPLEX_UNIT_SP, DEFAULT_TEXT_SIZE_SP);

LinearLayout ll2 = new LinearLayout(getContext());
ll2.setId(generateViewId());
ll2.setId(APILevel17.generateViewId());
lp = new RelativeLayout.LayoutParams(
android.view.ViewGroup.LayoutParams.MATCH_PARENT, panelHeight);
lp.setMargins(dlgMarging, 0, dlgMarging, dlgMarging/2);
Original file line number Diff line number Diff line change
@@ -332,7 +332,9 @@ protected void onCreate(Bundle state) {
//Initialize nfc adapter
NfcAdapter mNfcAdapter = NfcAdapter.getDefaultAdapter(this);
if (mNfcAdapter != null) {
mNfcAdapter.setBeamPushUrisCallback(new NfcAdapter.CreateBeamUrisCallback() {
//FIXME: Disabled for now; Not familiar with NFC stuff [yet]
mNfcAdapter = null;
/* mNfcAdapter.setBeamPushUrisCallback(new NfcAdapter.CreateBeamUrisCallback() {
@Override
public Uri[] createBeamUris(NfcEvent event) {
List<FileSystemObject> selectedFiles =
@@ -351,7 +353,7 @@ public Uri[] createBeamUris(NfcEvent event) {
}
return null;
}
}, this);
}, this);*/
}

//Initialize activity
Original file line number Diff line number Diff line change
@@ -207,7 +207,7 @@ public View getView(int position, View convertView, ViewGroup parent) {
tvText2.setOnLongClickListener(this);
tvText2.setTag(String.format("%d|%d", position, menuItem2.getItemId())); //$NON-NLS-1$
} else {
tvText2.setBackground(null);
tvText2.setBackgroundDrawable(null); // Fix for CM9 (ICS)
tvText2.setClickable(false);
tvText2.setOnClickListener(null);
tvText2.setOnLongClickListener(null);
4 changes: 2 additions & 2 deletions src/com/cyanogenmod/filemanager/ui/ThemeManager.java
Original file line number Diff line number Diff line change
@@ -463,14 +463,14 @@ public void setBackgroundDrawable(Context ctx, View view, String resource) {
String resId = String.format("%s_%s", this.mId, resource); //$NON-NLS-1$
int id = this.mResources.getIdentifier(resId, "drawable", this.mPackage); //$NON-NLS-1$
if (id != 0) {
view.setBackground(this.mResources.getDrawable(id));
view.setBackgroundDrawable(this.mResources.getDrawable(id));
return;
}

// Default theme
id = mDefaultTheme.mResources.getIdentifier(
resource, "drawable", mDefaultTheme.mPackage); //$NON-NLS-1$
view.setBackground(mDefaultTheme.mResources.getDrawable(id));
view.setBackgroundDrawable(mDefaultTheme.mResources.getDrawable(id));
}

/**
Original file line number Diff line number Diff line change
@@ -304,7 +304,7 @@ public void run() {
boolean mountAllowed = MountPointHelper.isMountAllowed(this.mMountPoint);
if (mountAllowed) {
this.mInfoMsgView.setVisibility(View.GONE);
this.mInfoMsgView.setBackground(null);
this.mInfoMsgView.setBackgroundDrawable(null); // Fix for CM9 (ICS)
this.mSwStatus.setEnabled(true);
this.mIsMountAllowed = true;
break;
Original file line number Diff line number Diff line change
@@ -532,7 +532,7 @@ public void onClick(View v) {
if (superuser) {
this.mInfoMsgView.setOnClickListener(null);
this.mInfoMsgView.setVisibility(View.GONE);
this.mInfoMsgView.setBackground(null);
this.mInfoMsgView.setBackgroundDrawable(null); // Fix for CM9 (ICS)

// Enable controls
this.mSpnOwner.setEnabled(true);
Original file line number Diff line number Diff line change
@@ -87,7 +87,7 @@ private void init() {
@Override
public void onGlobalLayout() {
SelectionView.this.mViewHeight = getHeight();
getViewTreeObserver().removeOnGlobalLayoutListener(this);
getViewTreeObserver().removeGlobalOnLayoutListener(this); // Fix for CM9 (ICS)
setVisibility(View.GONE);
LayoutParams params = (LayoutParams)SelectionView.this.getLayoutParams();
params.height = 0;
Original file line number Diff line number Diff line change
@@ -66,6 +66,6 @@ public TransparentNonFocusableButtonItem(Context context, AttributeSet attrs, in
*/
private void init() {
//Remove focus
setBackground(null);
setBackgroundDrawable(null); // Fix for CM9 (ICS)
}
}
2 changes: 1 addition & 1 deletion tests/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

<original-package android:name="com.cyanogenmod.filemanager.test" />

<uses-sdk android:minSdkVersion="17" android:targetSdkVersion="17" />
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="14" />

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.MOUNT_UNMOUNT_FILESYSTEMS" />