Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding the JVM #12

Open
andycate opened this issue Feb 3, 2019 · 0 comments
Open

Finding the JVM #12

andycate opened this issue Feb 3, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@andycate
Copy link
Member

andycate commented Feb 3, 2019

Currently, the first time the app is run, MonkeyPath tries to find the location of the JVM on the user's machine, and then writes the location to a file. The issue is that because the location is only known after the first run, the application has to be opened, closed, and then reopened for it to start working after installation. So far this only seems to be an issue with windows. On mac, the application works the first time.

From what I understand, when the installer runs on windows, it runs the application for the first time with a certain flag set that you can detect in the code. So basically, you need to detect that tag, run the bit of code that finds the JVM, and then kill the program. If that flag isn't present, then the program can run normally.

See this for more: https://github.com/electron/windows-installer#handling-squirrel-events

@andycate andycate added the bug Something isn't working label Feb 3, 2019
@andycate andycate self-assigned this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant