fix: error messages for > do not have the operands flipped

Author: hishamhm

spec/lang/operator/ge_spec.lua

@@ -0,0 +1,41 @@
+local util = require("spec.util")
+
+describe(">=", function()
+   it("ok", util.check([[
+      local x = 1
+      local y = 2
+      local z = true
+      if x >= y then
+         z = false
+      end
+   ]]))
+
+   it("fail", util.check_type_error([[
+      local x = 1
+      local y = "hello"
+      local z = true
+      if x >= y then
+         z = false
+      end
+   ]], {
+      { msg = "cannot use operator '>=' for types integer and string" }
+   }))
+
+   it("fails with not gotcha", util.check_type_error([[
+      local x = 10
+      local y = 20
+      if not x >= y then
+         print("wat")
+      end
+   ]], {
+      { msg = "cannot use operator '>=' for types boolean and integer" }
+   }))
+
+   it(">= on aliases to comparable types return boolean", util.check([[
+      local type Test = integer
+
+      local function f(a: Test, b: Test) : boolean
+         return a >= b
+      end
+   ]]))
+end)

spec/lang/operator/gt_spec.lua

@@ -0,0 +1,41 @@
+local util = require("spec.util")
+
+describe(">", function()
+   it("ok", util.check([[
+      local x = 1
+      local y = 2
+      local z = true
+      if x > y then
+         z = false
+      end
+   ]]))
+
+   it("fail", util.check_type_error([[
+      local x = 1
+      local y = "hello"
+      local z = true
+      if x > y then
+         z = false
+      end
+   ]], {
+      { msg = "cannot use operator '>' for types integer and string" }
+   }))
+
+   it("fails with not gotcha", util.check_type_error([[
+      local x = 10
+      local y = 20
+      if not x > y then
+         print("wat")
+      end
+   ]], {
+      { msg = "cannot use operator '>' for types boolean and integer" }
+   }))
+
+   it("> on aliases to comparable types return boolean", util.check([[
+      local type Test = integer
+
+      local function f(a: Test, b: Test) : boolean
+         return a > b
+      end
+   ]]))
+end)

spec/lang/operator/le_spec.lua

@@ -0,0 +1,41 @@
+local util = require("spec.util")
+
+describe("<=", function()
+   it("ok", util.check([[
+      local x = 1
+      local y = 2
+      local z = true
+      if x <= y then
+         z = false
+      end
+   ]]))
+
+   it("fail", util.check_type_error([[
+      local x = 1
+      local y = "hello"
+      local z = true
+      if x <= y then
+         z = false
+      end
+   ]], {
+      { msg = "cannot use operator '<=' for types integer and string" }
+   }))
+
+   it("fails with not gotcha", util.check_type_error([[
+      local x = 10
+      local y = 20
+      if not x <= y then
+         print("wat")
+      end
+   ]], {
+      { msg = "cannot use operator '<=' for types boolean and integer" }
+   }))
+
+   it("<= on aliases to comparable types return boolean", util.check([[
+      local type Test = integer
+
+      local function f(a: Test, b: Test) : boolean
+         return a <= b
+      end
+   ]]))
+end)

tl.lua

@@ -12611,6 +12611,10 @@ self:expand_type(node, values, elements) })
                   end
                   if mt_name then
                      t, meta_on_operator = self:check_metamethod(node, mt_name, ra, rb, ua, ub, flipped)
+                     if flipped and not meta_on_operator then
+                        ra, rb = rb, ra
+                        ua, ub = ub, ua
+                     end
                   end
                   if not t then
                      t = self.errs:invalid_at(node, "cannot use operator '" .. node.op.op:gsub("%%", "%%%%") .. "' for types %s and %s", ua, ub)

tl.tl

@@ -12611,6 +12611,10 @@ do
                   end
                   if mt_name then
                      t, meta_on_operator = self:check_metamethod(node, mt_name, ra, rb, ua, ub, flipped)
+                     if flipped and not meta_on_operator then
+                        ra, rb = rb, ra
+                        ua, ub = ub, ua
+                     end
                   end
                   if not t then
                      t = self.errs:invalid_at(node, "cannot use operator '" .. node.op.op:gsub("%%", "%%%%") .. "' for types %s and %s", ua, ub)