Environment variable EGI_SITE not used

[thebe14]

The environment variable EGI_SITE is set to a site name, but fedcloud does not use it, instead it insists to provide parameter --site or --all-sites.

Environment

• Operating System: Ubuntu 22.04
• Other related components versions: fedcloud version 1.2.15

Steps to reproduce

• Provision a new VM
• Install fedcloudclient
• Set environment variable EGI_VO and EGI_SITE
• Run command e.g. fedcloud openstack server list

Error message is shown:

Error: Missing one of the required mutually exclusive options from 'Site' option group:
  '--site'
  '--all-sites' / '-a'

[thebe14]

Same thing happens on Windows (fedcloud version 1.2.14).

[tdviet]

Thanks for report. It is the bug of click-option-group library, concretely the classes RequiredAnyOptionGroup and RequiredMutuallyExclusiveOptionGroup, that check the requirements of parameters only via CLI options.

Fixing this bug properly requires more times. We can temporarily disable the requirement checking to make the fedclouclient work for your case. However if users forget to set site option, they will receive nonsense error messages "VO xxx is missing on site None".

[tdviet]

To be fixed in the planned fedcloud.config module, that will read config files + relevant environment variables during initialization and set all global variables (including default site and VO) accordingly, so we can ignore requirements checking via click-option-group.

[tdviet]

To be fixed in #86

[tdviet]

Disable support EGI_SITE ennvar and remove it from documentation. d889dbb

A systematic solution for setting site via config module (with a new envvar FEDCLOUD_SITE) will be introduced in the new major release. More info in #86