From 111de5a18bcc88bf1863ba5c9d8da5f10fc2df1c Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 27 Mar 2024 06:35:04 +1100 Subject: [PATCH] Bump MSRV to 1.56.1 We want to depend on the newly released version of `hashes` which has an MSRV of 1.56.1 `hashes` is an optional dependency so we either bump the MSRV here or document that enabling `hashes` increases the MSRV. Also bumps MSRV of `secp256k1-sys` to keep the whole repository on the same MSRV although this is not strictly necessary we would have to patch CI to test secp-sys with 1.48 if we do not bump its MSRV also. --- .github/workflows/rust.yml | 4 ++-- Cargo.toml | 3 ++- README.md | 2 +- secp256k1-sys/Cargo.toml | 3 ++- secp256k1-sys/README.md | 2 +- 5 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 9297ba0c0..f8f768151 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -55,7 +55,7 @@ jobs: run: ./contrib/test.sh MSRV: - name: Test - 1.48.0 toolchain + name: Test - 1.56.1 toolchain runs-on: ubuntu-latest strategy: fail-fast: false @@ -63,7 +63,7 @@ jobs: - name: Checkout Crate uses: actions/checkout@v3 - name: Checkout Toolchain - uses: dtolnay/rust-toolchain@1.48.0 + uses: dtolnay/rust-toolchain@1.56.1 - name: Running test script env: DO_FEATURE_MATRIX: true diff --git a/Cargo.toml b/Cargo.toml index 942835bb7..b6e1dcf72 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -10,7 +10,8 @@ documentation = "https://docs.rs/secp256k1/" description = "Rust wrapper library for Pieter Wuille's `libsecp256k1`. Implements ECDSA and BIP 340 signatures for the SECG elliptic curve group secp256k1 and related utilities." keywords = [ "crypto", "ECDSA", "secp256k1", "libsecp256k1", "bitcoin" ] readme = "README.md" -edition = "2018" +edition = "2021" +rust-version = "1.56.1" [package.metadata.docs.rs] all-features = true diff --git a/README.md b/README.md index ca4efa31b..10ead79a1 100644 --- a/README.md +++ b/README.md @@ -29,7 +29,7 @@ Contributions to this library are welcome. A few guidelines: * Any breaking changes must have an accompanied entry in CHANGELOG.md * No new dependencies, please. * No crypto should be implemented in Rust, with the possible exception of hash functions. Cryptographic contributions should be directed upstream to libsecp256k1. -* This library should always compile with any combination of features on **Rust 1.48.0**. +* This library should always compile with any combination of features on **Rust 1.56.1**. ### Githooks diff --git a/secp256k1-sys/Cargo.toml b/secp256k1-sys/Cargo.toml index f565c5bd9..2ca55b53d 100644 --- a/secp256k1-sys/Cargo.toml +++ b/secp256k1-sys/Cargo.toml @@ -13,7 +13,8 @@ keywords = [ "secp256k1", "libsecp256k1", "ffi" ] readme = "README.md" build = "build.rs" links = "rustsecp256k1_v0_9_2" -edition = "2018" +edition = "2021" +rust-version = "1.56.1" [package.metadata.docs.rs] all-features = true diff --git a/secp256k1-sys/README.md b/secp256k1-sys/README.md index 3305e2d37..5129aa0f7 100644 --- a/secp256k1-sys/README.md +++ b/secp256k1-sys/README.md @@ -49,4 +49,4 @@ to your `RUSTFLAGS` variable. ## Minimum Supported Rust Version -This library should always compile with any combination of features on **Rust 1.48.0**. +This library should always compile with any combination of features on **Rust 1.56.1**.