Skip to content

Commit b137630

Browse files
committed
.github: use Debug build for header dependency verification
The existing GitHub workflow uses `RelWithDebInfo` configuration when running clang-include-cleaner, which can miss header dependencies conditionally compiled with SEASTAR_DEBUG. This change switches the workflow to use Debug configuration to ensure: - Proper detection of headers guarded by `SEASTAR_DEBUG` - Correct verification of conditional include statements - Accurate identification of truly unused headers Specifically, this addresses the false-positive detection of utils/assert.hh as an unused header, which is conditionally included when SEASTAR_DEBUG is defined. Signed-off-by: Kefu Chai <[email protected]>
1 parent 90a959a commit b137630

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/iwyu.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- master
77

88
env:
9-
BUILD_TYPE: RelWithDebInfo
9+
BUILD_TYPE: Debug
1010
BUILD_DIR: build
1111
CLEANER_OUTPUT_PATH: build/clang-include-cleaner.log
1212
# the "idl" subdirectory does not contain C++ source code. the .hh files in it are

0 commit comments

Comments
 (0)