Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-indented text does not produce a warning #536

Closed
justingrant opened this issue Jun 29, 2023 · 2 comments
Closed

Double-indented text does not produce a warning #536

justingrant opened this issue Jun 29, 2023 · 2 comments

Comments

@justingrant
Copy link

From tc39/proposal-temporal#2621 (comment):

The following spec text did not produce any complaints from ecmarkup. I would have expected that only one additional level of indentation (two spaces) is allowed.

      1. Else if _parseResult_ contains a |UTCOffsetSubMinutePrecision| Parse Node, then
          1. Let _offset_ be the source text matched by the |UTCOffsetSubMinutePrecision| Parse Node contained within _parseResult_.
          1. Set _timeZoneResult_.[[OffsetString]] to CodePointsToString(_offset_).
@bakkot
Copy link
Contributor

bakkot commented Jun 29, 2023

Handling of whitespace is generally managed by the formatter, not the build job, and indeed if you run the formatter on this input it will fix it for you.

@justingrant
Copy link
Author

Oh! Got it, sorry for the spam. The spec workflow in the Temporal repo has never used the formatter, but as we get closer to Stage 4 we should start using it. Issue opened. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants