Skip to content

Commit 3428585

Browse files
committed
Address mficarra review
- Make waitable in ValidateIntegerTypedArray non-optional - Fix ValidateTypedArray reference in %TA%.p.toLocaleString
1 parent b4c8ea3 commit 3428585

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

spec.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41159,7 +41159,7 @@ <h1>%TypedArray%.prototype.subarray ( _begin_, _end_ )</h1>
4115941159
<emu-clause id="sec-%typedarray%.prototype.tolocalestring">
4116041160
<h1>%TypedArray%.prototype.toLocaleString ( [ _reserved1_ [ , _reserved2_ ] ] )</h1>
4116141161
<p>This is a distinct method that implements the same algorithm as `Array.prototype.toLocaleString` as defined in <emu-xref href="#sec-array.prototype.tolocalestring"></emu-xref> except that IntegerIndexedObjectLength is called in place of performing a [[Get]] of *"length"*. The implementation of the algorithm may be optimized with the knowledge that the *this* value has a fixed length when the underlying buffer is not resizable and whose <emu-xref href="#integer-index">integer-indexed</emu-xref> properties are not sparse. However, such optimization must not introduce any observable changes in the specified behaviour of the algorithm.</p>
41162-
<p>This method is not generic. ValidateTypedArray is applied to the *this* value prior to evaluating the algorithm. If its result is an abrupt completion that exception is thrown instead of evaluating the algorithm.</p>
41162+
<p>This method is not generic. ValidateTypedArray is called with the *this* value and ~SeqCst~ as arguments prior to evaluating the algorithm. If its result is an abrupt completion that exception is thrown instead of evaluating the algorithm.</p>
4116341163
<emu-note>
4116441164
<p>If the ECMAScript implementation includes the ECMA-402 Internationalization API this method is based upon the algorithm for `Array.prototype.toLocaleString` that is in the ECMA-402 specification.</p>
4116541165
</emu-note>
@@ -44171,13 +44171,12 @@ <h1>Abstract Operations for Atomics</h1>
4417144171
<h1>
4417244172
ValidateIntegerTypedArray (
4417344173
_typedArray_: an ECMAScript language value,
44174-
optional _waitable_: a Boolean,
44174+
_waitable_: a Boolean,
4417544175
): either a normal completion containing an Integer-Indexed Object With Buffer Witness Record, or a throw completion
4417644176
</h1>
4417744177
<dl class="header">
4417844178
</dl>
4417944179
<emu-alg>
44180-
1. If _waitable_ is not present, set _waitable_ to *false*.
4418144180
1. Let _iieoRecord_ be ? ValidateTypedArray(_typedArray_, ~Unordered~).
4418244181
1. NOTE: Bounds checking is not a synchronizing operation when _typedArray_'s backing buffer is a growable SharedArrayBuffer.
4418344182
1. If _waitable_ is *true*, then

0 commit comments

Comments
 (0)