Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest #8

Closed
4 of 6 tasks
tattali opened this issue Apr 5, 2022 · 0 comments
Closed
4 of 6 tasks

Manifest #8

tattali opened this issue Apr 5, 2022 · 0 comments

Comments

@tattali
Copy link
Owner

tattali commented Apr 5, 2022

Hi everyone,

The last commit of the main repository suncat2000/MobileDetectBundle is over 2 years old now. Since the project seems abandoned by its author, I decided to create and maintain a fork tattali/MobileDetectBundle.

The fork is available now and you will find instructions for using it in the README.

Of course, if you are ready to help, do not hesitate to contact me!

If you have any question, don't hesitate to ask! 👍

What have been done so far:

Highlights

  • Full compatibility with Symfony 3.4 to 6
  • Rework README.md to clarify the meaning of the bundle
  • Maintain test coverage to 94%
  • Create MobileDetectorInterface interface of Mobile_Detect class
Full details

Documentation

  • Rework README.md to clarify the meaning of the bundle
  • Create a new logo with mobile detect and symfony bundle

CI

Configuration

  • Convert services to YAML files
  • Use class names as ids in services to respect new best practices and alias to old ids
  • Rename mobile_detect.cookie_httponly to mobile_detect.cookie_httpOnly
  • Drop mobile_detect.mobile_detector.class, mobile_detect.device_view.class, mobile_detect.request_response_listener.class, mobile_detect.twig.extension.class

Improvements

  • Create MobileDetectorInterface interface of Mobile_Detect fully compatible with mobiledetect/mobiledetectlib >=2.8.15
  • Create MobileDetectBundle\DeviceDetector\MobileDetectorInterface service to quickly access the lib
  • Add an is_windows_os in the twig extension
  • Add an rules_list in the twig extension

Drops

  • Drop active support for Symfony <5.1 see Legacy version to use the bundle
  • Drop support for PHP <7.2.5
  • Drop support for mobiledetect/mobiledetectlib <2.8.15
  • Drop support for Symfony 2.8 and <3.4 (non flex version)
  • Drop psr-0 in favour of psr-4 and rename namespace as neutral MobileDetectBundle\

Others

  • Move the Main bundle to src and tests to tests folders
  • Add small Makefile
  • Enable active support of mobiledetect/mobiledetectlib >= 2.8.15
  • Clean php-doc with php8 compatible types and remove unnecessary documentation
  • Add native php typing where it’s possible
  • Rename cookieSamesite by cookieSameSite in whole project

Planned work for next release:

  • Continue the rework of the documentation
  • Test and document all the features of the bundle (redirection...)
  • Ensure the compatibility with Symfony6 and future version
  • Create a dedicated recipe
  • Review and integrate the pending issues and PR of the main repo to the fork
  • Create a edge version Compatible with PHP >=8.0, Symfony >=6.0 and MobileDetect php7.4

EDIT: Every features documented in the README are working at full capacity
Do not hesitate to open an issue if you found a bug.

Enjoy! 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant