Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use truncated and terminated return values correctly #16

Open
clemens-fricke opened this issue Nov 23, 2023 · 0 comments
Open

Use truncated and terminated return values correctly #16

clemens-fricke opened this issue Nov 23, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@clemens-fricke
Copy link
Member

Is your feature request related to a problem? Please describe.
When this package was first written, stable_baselines3 did not differentiate between different reasons for terminating an episode. But a few versions ago this changed. There are now two different episode termination variables:
terminated and truncated

I at some point saw this change and did a quick and dirty fix (I think) in the framework, but did not understand what the difference was back then. Now I just came by this part of the sb3 documentation that goes a little bit into the difference link to the docu part.

This needs to be implemented correctly so that we can give the agents the best possible information to train from.

Describe the solution you'd like
Adapt the correct variable to the end state if the episode is terminated.

@clemens-fricke clemens-fricke added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant