Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPOR step checks if observations are present #11

Open
clemens-fricke opened this issue Aug 23, 2023 · 0 comments
Open

SPOR step checks if observations are present #11

clemens-fricke opened this issue Aug 23, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@clemens-fricke
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, the SPOR steps do not check if the observations defined for them are actually produced in each step. This will make the training crash with weird error messages.

Describe the solution you'd like
two possible solutions are possible

  1. Define default observations if no/too few observations are provided. (What do we do if there are too many?) AND write a warning to the log saying that observations were amended with default observations. The episode should also be terminated at this point.
  2. Raise an error saying this specific step did not provide the observations that it should.

This is currently seen as a nice to have but not an urgent feature.

@clemens-fricke clemens-fricke added enhancement New feature or request good first issue Good for newcomers labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant