Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft add update + v0.0.25 #202

Merged
merged 12 commits into from
May 6, 2024
Merged

Ft add update + v0.0.25 #202

merged 12 commits into from
May 6, 2024

Conversation

j042
Copy link
Member

@j042 j042 commented Apr 10, 2024 •
edited
Loading

Adds DataHolder.update() and bump version

As part of v0.0.25 this PR also includes:

  • helper tests
  • io export signature export(fname, mesh) instead of other way around
  • workflow updates

clemens-fricke
clemens-fricke previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@clemens-fricke clemens-fricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thank You. Only a test would be nice to have.

@j042
Copy link
Member Author

j042 commented Apr 22, 2024

Looks good, Thank You. Only a test would be nice to have.

good idea!

@j042
Copy link
Member Author

j042 commented Apr 23, 2024

Looks good, Thank You. Only a test would be nice to have.

good idea!

working on some test for helpers. I will create a new PR for it

@j042 j042 mentioned this pull request Apr 23, 2024
Merged
@j042
Copy link
Member Author

j042 commented Apr 23, 2024

see #205 for tests

@clemens-fricke
Copy link
Collaborator

Thank you. Merge it at will.

@j042 j042 force-pushed the ft-add-update branch from 1987587 to 3621a79 Compare May 2, 2024 18:30
@j042
Copy link
Member Author

j042 commented May 2, 2024

need to update workflow - macos-latest is now arm

@j042 j042 changed the title Ft add update Ft add update + v0.0.25 May 3, 2024
@j042 j042 requested a review from clemens-fricke May 3, 2024 07:46
danielwolff1
danielwolff1 approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@danielwolff1 danielwolff1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a glance at the changes and it's looking good from my side, including the test!

@j042 j042 merged commit 5b47395 into main May 6, 2024
22 checks passed
@j042 j042 deleted the ft-add-update branch May 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwolff1 danielwolff1 danielwolff1 approved these changes

@jzwar jzwar Awaiting requested review from jzwar

@clemens-fricke clemens-fricke Awaiting requested review from clemens-fricke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j042 @clemens-fricke @danielwolff1