fix: check readiness before timeout#600
Open
ans-artal wants to merge 1 commit intotaskiq-python:masterfrom
Open
fix: check readiness before timeout#600ans-artal wants to merge 1 commit intotaskiq-python:masterfrom
ans-artal wants to merge 1 commit intotaskiq-python:masterfrom
Conversation
I think that when a task completes as the timeout expire, the code should return the result rather than raise.
Member
|
Yeah, that could help a bit. Thanks for your contribution. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage ? 78.45%
=========================================
Files ? 68
Lines ? 2413
Branches ? 0
=========================================
Hits ? 1893
Misses ? 520
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that when a task completes as the timeout expire, the code should return the result rather than raise.